Notice after deleting aggregator feed

so far I can't reproduce on 7.x, so this may be a 6.x bug.

Now can reproduce - an extra step is needed:

Before deleting the feed enable the block specific to that feed.

Once the feed is deleted this notice appears but then the block does not appear in the blocks UI at admin/build/block, but the notice appears on every page.

The error is in function aggregator_block() - the cause may be that the block corresponding to that feed is not deleted from the {blocks} table.

If you visit the admin/build/block page then the blocks are rebuilt and the notice goes away.

Basically the same thing happens if you delete a category which has an enabled block:

notice: Undefined variable: result in modules/aggregator/aggregator.module on line 337.

The code from hook_block shows how the block deltas are built:

      $result = db_query('SELECT cid, title FROM {aggregator_category} ORDER BY title');
      while ($category = db_fetch_object($result)) {
        $block['category-' . $category->cid]['info'] = t('!title category latest items', array('!title' => $category->title));
      }
      $result = db_query('SELECT fid, title FROM {aggregator_feed} ORDER BY fid');
      while ($feed = db_fetch_object($result)) {
        $block['feed-' . $feed->fid]['info'] = t('!title feed latest items', array('!title' => $feed->title));
      }

Patch attached for 7.x. Initial tests suggests that it resolves the bug. The 6.x backport should be simple- just change the spacing of the concat.

by convention the "_" means that this is not really a public function. Basically block module is broken is as much as it does not offer a readily available public function for this purpose. We can use it for D6, but perhaps we should reform block module a little for D7.