Closed (fixed)
Project:
Remote image
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Mar 2016 at 05:10 UTC
Updated:
16 May 2017 at 08:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
xaiwant commentedupdated README.md attached updated patch
Comment #3
joshi.rohit100content or contents ?
Comment #4
xaiwant commentedHi @joshi.rohit100
Please refer below URL for documentation guidance.
https://www.drupal.org/node/2181737
Comment #5
Sonal.Sangale commentedComment #6
anavarreWe usually wrap lines at 80 cols.
80 cols.
s/module(/module (/
"After the module has been successfully enabled, ..."
"field of type ..."
Also, 80 cols.
"a custom widget and field formatter."
maintainer
Comment #7
anavarreComment #8
harsha012 commentedupdated patch as per the comment #6
Comment #9
anavarreThinking about this more, since we have only one maintainer, we should probably go with "Maintainer"
I suggest "Field (to add fields to entities like nodes and users.)" so that we don't repeat "module" over and over again.
How about "a custom widget"?
MAINTAINER
Per the above, we can drop this line completely.
Comment #10
harsha012 commented@anavarre added the patch as per comment #8
Comment #11
anavarreAlmost!
Should be "Maintainer", or, if we keep "Maintainers", then the below "MAINTAINER" section needs to be pluralized.
I'd simply reword this as "This module has a dependency on the core Field module, to add fields to entities, like nodes and users."
"with a custom widget and field formatter."
Comment #12
Sonal.Sangale commentedUpdated patch as per comment #11
Comment #13
anavarreThis line should be wrapped at 80 cols.
Since this can easily fixed on commit, I'm tentatively marking it as RTBC, pending @dawehner's review. Thanks for sticking to it.
Comment #14
xaiwant commented@anavarre
line wrapped with 80 cols.
Comment #15
anavarreThanks, but you forgot a comma and invisible space at the end of line.
Comment #16
xaiwant commentedcomma shifted to next line and removed invisible space at the end of line
Comment #17
anavarreMissing whitespace between "," and "like", but this can be fixed on commit.
Comment #18
renatog commented-
Comment #19
renatog commentedFixed @anavarre.
Patch it's in attachment.
Good Work.
Regards.
Comment #20
renatog commentedComment #21
dawehnerThank you @RenatoG!