Follow-up to #2649914: Enforce formatter dependencies on views fields

Problem/Motivation

The update text says "Update dependencies to image style." This is wrong for a number of reasons - it is updating views dependencies and it is update them to have any field formatter dependencies which include image styles.

Proposed resolution

Fix text and move update function to bottom of file to be in the order expected by @addtogroup annotations.

Remaining tasks

User interface changes

Text change on update.php

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 interdiff.txt607 bytesclaudiu.cristea
#5 2683263-5.patch1.11 KBclaudiu.cristea
#2 2683263-2.patch1.11 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2683263-2.patch1.11 KB
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Straight.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

We should rename it as well to not be image_style_dependencies().

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new 2683263-5.patch1.11 KB
new interdiff.txt607 bytes

Renamed.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

I guess this is RTBC again because the's only a rename.

dawehner’s picture

dawehner
Primary language German
commented

Wait, won't this execute the same function twice now potentially?

catch’s picture

catch
he/him
Primary language English
commented

Well it could, but it's re-entrant so does that matter during beta?

dawehner’s picture

dawehner
Primary language German
commented

Given that we here just talk about resaving all the views, so something which doesn't cause any harm, I think we are risk free here, so let's just do it.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yes and it will only run twice on sites that already updated anyway, and therefore not even in the same update run.

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

  • catch committed 0dc48d0 on 8.2.x 
    Issue #2683263 by claudiu.cristea, alexpott: Update text for...

  • catch committed 814a982 on 8.1.x 
    Issue #2683263 by claudiu.cristea, alexpott: Update text for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.