When I run a Drupal cache clear, the css_js_query_string variable gets reset, which avoids having to hard-clear my browser's cached files in order to get updated JS. However, CKEditor uses its own cache-busting string, and the scripts loaded by CKEditor can get out of date when doing a deployment. It would be good to force CKEditor to re-use the same string.

This was a particular problem with an install profile I was using that provided it's own 'customConfig' file.

For reference:
http://ckeditor.com/forums/CKEditor/Problem-with-config.js-not-updating
http://ckeditor.com/forums/CKEditor/howto-disable-anti-cache-for-toolbar...
http://stackoverflow.com/questions/14940452/force-ckeditor-to-refresh-co...

CommentFileSizeAuthor
#2 Selection_351.png80.17 KBdave reid
#2 Selection_350.png79.23 KBdave reid
#2 2679179-ckeditor-reuse-cache-busting-query.patch1.46 KBdave reid

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2679179-ckeditor-reuse-cache-busting-query.patch1.46 KB
new Selection_350.png79.23 KB
new Selection_351.png80.17 KB

Patch for review along with the before & after source of the CKEditor-related JS file URLs.

Current behavior:

After patch:

Status: Needs review » Needs work

The last submitted patch, 2: 2679179-ckeditor-reuse-cache-busting-query.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Already landed in Drupal 8 core, with test coverage: #2679903: CKEditor uses separate cache-busting query string from Drupal's.

pounard’s picture

pounard
Primary language French
commented

This should definitely be commited and released.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

This issue is on needs work because by this other one #2745809: Add some tests to avoid failed testing of all patches is stopped.

Once the other patch is commited CI can be used.

Reviews are wellcome to unblock the IQ.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
hass’s picture

hass commented
Parent issue: » #2330515: Cache-bust CKEditor Styles and Config files

Duplicate of

sgdev’s picture

sgdev commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2679106: CKEditor uses separate cache-busting query string from Drupal's

This same patch from the same author was committed a year ago for WYSIWYG: https://www.drupal.org/project/wysiwyg/issues/2679106

Have reviewed and should be committed here too.

  • jcisio committed 788e1f2 on 7.x-1.x authored by Dave Reid 
    Issue #2679179 by Dave Reid, ron_s: CKEditor uses separate cache-busting...
jcisio’s picture

jcisio commented
Status: Reviewed & tested by the community » Fixed

Thank you. I checked the patch and it actually looks good. Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.