The plan is for when a workspace is marked as approved, then Workspace automatically replicates it.

Comments

juampynr created an issue. See original summary.

timmillwood’s picture

Project: Multiversion » Workspace
Issue summary: View changes

Moving to Workspace module.

Crell’s picture

Assigned: Unassigned » Crell

Starting on this.

Crell’s picture

Status: Active » Needs review
StatusFileSize
new4.49 KB

Here's a first take. This should probably have tests, but I'm not quite sure how to set that up. (Help welcome.) Also, there's a couple of @todos in the code that I'd like guidance on from Tim or Dixon.

timmillwood’s picture

StatusFileSize
new714 bytes
new4.57 KB

The patch in #4 prevents Workspace from being installed until Workbench Moderation has been installed.

Updated the patch to add a check that \Drupal\workbench_moderation\Event\WorkbenchModerationEvents exists.

Also I am still getting the following error when editing a workspace, will add or update a WBM issue for this:
Uncaught PHP Exception Exception: "entity.workspace.latest_version is not a valid entity route. The LatestRevisionCheck access checker may only be used with a route that has a single entity parameter." at /home/timmillwood/Code/drupal/modules/workbench_moderation/src/Access/LatestRevisionCheck.php line 8

Crell’s picture

Oh good grief, I hadn't even thought of that problem. Good change.

The latest_version issue is caused by #2678316: Don't create latest-version route/tab unless there's a canonical tab.

  • timmillwood committed f435fa5 on 8.x-1.x authored by Crell
    Issue #2678034 by timmillwood, Crell: Integrate Workbench Moderation...
timmillwood’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.