The plan is for when a workspace is marked as approved, then Workspace automatically replicates it.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | integrate_workbench-2678034-5.patch | 4.57 KB | timmillwood |
| #5 | interdiff.txt | 714 bytes | timmillwood |
The plan is for when a workspace is marked as approved, then Workspace automatically replicates it.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | integrate_workbench-2678034-5.patch | 4.57 KB | timmillwood |
| #5 | interdiff.txt | 714 bytes | timmillwood |
Comments
Comment #2
timmillwoodMoving to Workspace module.
Comment #3
Crell commentedStarting on this.
Comment #4
Crell commentedHere's a first take. This should probably have tests, but I'm not quite sure how to set that up. (Help welcome.) Also, there's a couple of @todos in the code that I'd like guidance on from Tim or Dixon.
Comment #5
timmillwoodThe patch in #4 prevents Workspace from being installed until Workbench Moderation has been installed.
Updated the patch to add a check that
\Drupal\workbench_moderation\Event\WorkbenchModerationEventsexists.Also I am still getting the following error when editing a workspace, will add or update a WBM issue for this:
Uncaught PHP Exception Exception: "entity.workspace.latest_version is not a valid entity route. The LatestRevisionCheck access checker may only be used with a route that has a single entity parameter." at /home/timmillwood/Code/drupal/modules/workbench_moderation/src/Access/LatestRevisionCheck.php line 8Comment #6
Crell commentedOh good grief, I hadn't even thought of that problem. Good change.
The latest_version issue is caused by #2678316: Don't create latest-version route/tab unless there's a canonical tab.
Comment #8
timmillwood