Misleading instructions after enabling a module.

cpugeniusmv, this looks good but it might be good to add a code comment that provides some context.

I don't think this is the right patch for this problem. This clobbers the information about the last time we checked for updates. That's printed in the UI, and just because the cache is invalidated for some reason doesn't erase the fact that we last checked for updates 5 hours ago or whatever it is.

Instead, we need to change the logic in cron when deciding if we need to check for updates to use logic something like:

if (!$have_any_data || $been_too_long_since_we_last_checked) {
  // Check for updates.
}

Code applies cleanly to d7 HEAD. Next cron update does update the module status page. +1 for RTBC.

No longer applied, attached is a new version. (time() was replaced by $_SERVER['REQUEST_TIME'] recently)

Simple problem, simple patch, wonderful result. Marking RTBC.

Needs a re-roll again due to REQUEST_TIME.

Could we also see a before/after screenshot of what this patch changes? http://webchick.net/visualize-your-patches Preferably with some arrows pointing to what's wrong. I didn't quite grok it from the original description.

Ok, I think I duplicated this bug (it's hard to tell, because there aren't really testing instructions in this issue, and the modules page is so FUBAR right now) via the following:

Before patch:

1. Enable Devel module
2. See message about no update information available
3. Click "run cron"
4. See that the message about no update information available persists

After patch:

1. Enable Devel module
2. See message about no update information available
3. Click "run cron"
4. See that the message about no update information available goes away

The latter behaviour looks to be an improvement, so I committed. Let me know if there's something I overlooked.

Marking down to 6.x.

Or I thought I did anyway. ;)

Yup, that is exactly the way it should behave. Because the message (by update.module) tells you to run cron to solve a problem, and running cron doesn't solve the problem. That's annoying, and fixed by this patch.

Thanks for commiting!

Attached is the version for D6.

Added two sets of parenthesis so that the relations are obvious on first sight. Committed this one.

Now available in D7 with more parens (as per Gabor). ;) Once this lands (again), I'll fix D5 update_status in contrib...

Fixed! (again :))

Thanks, webchick. ;)

Here's an untested backport to update_status D5 contrib.

Now that #155450: backport separate {cache_update_status} table and private non-volatile cache API from D6 core is fixed, I ported #23, tested, and committed the attached patch to DRUPAL-5--2.