Let's move the classes over to the Context namespace -- all the context handling depends on it and the classes are not bound to Rules at all. The only thing that seems to be rules-specific is \Drupal\rules\Engine\ExecutionState::$blocked - which is not implemented right now anyway. We could keep a rules-specific sub-class for that though?

CommentFileSizeAuthor
#5 2677094-5-move-execution-state-to-context.patch28.09 KBtr
#4 2677094-4-move-execution-state-to-context.patch27.54 KBtr

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Parent issue: » #2677098: [META] Provide Context related code as composer package
tr’s picture

tr commented
Issue tags: +beta blocker

If this is to be done, it should be done before beta because it is an API change.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 2677094-4-move-execution-state-to-context.patch27.54 KB

Let's see how many things this breaks.

tr’s picture

tr commented
StatusFileSize
new 2677094-5-move-execution-state-to-context.patch28.09 KB

That was better than I expected - just a few use statements that are now no longer needed ...

  • TR committed 231324d on 8.x-3.x 
    Issue #2677094 by TR: Execution state and execution metadata state...
tr’s picture

tr commented
Status: Needs review » Fixed

OK let's do this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.