CommentFileSizeAuthor
#3 seckit-fix_permission_created_by_module-2676794-3.patch1.03 KBperennial.sky
#2 seckit-fix_permission_created_by_module-2676794-1.patch1.01 KBperennial.sky

Comments

akashjain132 created an issue. See original summary.

perennial.sky’s picture

perennial.sky commented
Assigned: perennial.sky » Unassigned
Status: Active » Needs review
StatusFileSize
new seckit-fix_permission_created_by_module-2676794-1.patch1.01 KB

Here is the patch

perennial.sky’s picture

perennial.sky commented
StatusFileSize
new seckit-fix_permission_created_by_module-2676794-3.patch1.03 KB

Here is the new patch, since this permission is only for administrator role or someone trusted roles, So we need to show warning message on permission page by adding

restrict access: true parameter in permission file.

Here is the reference of removing hook_permission by *.permissions.yml file
https://www.drupal.org/node/2311427

badjava’s picture

badjava commented
Assigned: Unassigned » badjava

@akashjain132 Thank you for reporting this issue and the patch. I will review it soon.

novitsh’s picture

novitsh commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested the patch.
Cleanly applied and working.

Setting to RTBC.

badjava’s picture

badjava commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed. Thank you @akashjain132 for submitting this patch and @Novitsh for testing it.

jweowu’s picture

jweowu commented
Status: Closed (fixed) » Fixed

Reverting to just "Fixed". Fixed issues are closed automatically after two weeks, if there has been no further activity.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.