CommentFileSizeAuthor
#5 seckit-every_string-must_be_translatable-2676706-5.patch1.42 KBperennial.sky
#2 seckit-every_string-must_be_translatable-2676706-1.patch6.65 KBperennial.sky

Comments

akashjain132 created an issue. See original summary.

perennial.sky’s picture

perennial.sky commented
Status: Active » Needs review
StatusFileSize
new seckit-every_string-must_be_translatable-2676706-1.patch6.65 KB

Here is the patch

jweowu’s picture

jweowu commented
Status: Needs review » Needs work

Hi akashjain132. I'm afraid you're wrong about most of these.

CSP directives (e.g. default-src) are not to be translated. These are fixed names in the CSP specification, and translating them would mean that the SecKit UI could not be cross-referenced with the specification, which isn't acceptable.

Similarly for translating strings which are part of a HTTP header specification. For the X-Frame-Options values, the "Disabled" option is translated (already) because it is not a value in the header specification. The other options are names from the spec, and should not be translated.

Your remaining two changes for calls to drupal_set_message look valid. I'll commit those two if you roll a new patch (and fix the syntax error in the second one).

perennial.sky’s picture

perennial.sky commented
Assigned: Unassigned » perennial.sky
perennial.sky’s picture

perennial.sky commented
Assigned: perennial.sky » Unassigned
Status: Needs work » Needs review
StatusFileSize
new seckit-every_string-must_be_translatable-2676706-5.patch1.42 KB

Here is the new patch

jweowu’s picture

jweowu commented
Title: Every string must be translatable » Missing string translations
Status: Needs review » Fixed

Thanks akashjain132. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.