Hello,

I discovered this module today and does exactly what I need, however I found it's doing it in a non-performant way.

Module just hides using CSS the not desired toolbar, but HTML markup is still there. That makes site slower given that the HTML markup is heavier and also some unnecessary AJAX requests are executed.
Also page HTML is harder to debug because toolbar items are duplicated.

Here I'm proposing use a server side solution to hide the non-desired toolbar, instead of doing it via CSS.

What do you think?

CommentFileSizeAuthor
#5 interdiff-2674714-2-5.txt1.09 KBdarol100
#5 Removing-HTMl-css-js-from-the-admin_menu-and-navbar-2674714-5.patch3.97 KBdarol100
#2 remove_html_markup-2674714-2.patch2.38 KBplopesc

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new remove_html_markup-2674714-2.patch2.38 KB

Attaching patch.

Hope you find it useful.

Thanks.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: Remove unwanted HTML markup instead of hiding it » Remove unwanted toolbar HTML markup instead of hiding it
darol100’s picture

darol100 commented
StatusFileSize
new Removing-HTMl-css-js-from-the-admin_menu-and-navbar-2674714-5.patch3.97 KB
new interdiff-2674714-2-5.txt1.09 KB

@plopesc, Great work. I do not remember why I did not build it like this at the first place. I have update your path with some minor modification. I have removed it the CSS and JS from that is been load it whenever those menu have been load it.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Much better!

I think module is much more robust and light at the same time!

Could you commit and roll a new release?

Thanks!

  • darol100 committed 6c29f8e on 7.x-2.x 
    Issue #2674714 by darol100, plopesc: Remove unwanted toolbar HTML markup...
darol100’s picture

darol100 commented
Status: Reviewed & tested by the community » Fixed

Done and done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.