Problem/Motivation

There is no @return documentation for _buildArguments() in ViewExecutable.php

Proposed resolution

_buildArguments() returns TRUE if successful, FALSE if not. A comment should be added to note this.

CommentFileSizeAuthor
#2 missing-return-doc-for-buildArguments-2673552.patch560 bytesmcjim

Comments

mcjim created an issue. See original summary.

mcjim’s picture

mcjim commented
Status: Active » Needs review
StatusFileSize
new missing-return-doc-for-buildArguments-2673552.patch560 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.1.x-dev » 8.0.x-dev
Status: Needs review » Reviewed & tested by the community

OK. This can be done in 8.0.x as well.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x and cherry-picked to 8.0.x. Thanks!

  • catch committed f6995c0 on 8.0.x 
    Issue #2673552 by mcjim: Add missing @return documentation for...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

This only went to 8.0.x as far as I can see, so I committed it to 8.1.x as well.

  • jhodgdon committed 03474b6 on 8.1.x 
    Issue #2673552 by mcjim: Add missing @return documentation for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.