Comments

fago created an issue. See original summary.

fago’s picture

One can take "Create entity" action as an example.

klausi’s picture

Does that mean we replace the existing entity save action?

fago’s picture

hm, we could keep the generic "Save entity" in addition imho. It does not do harm and allows to save "entity" variables if one really has some

a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky
Issue summary: View changes

Started, see progress in PR.
Work in progress...

a.milkovsky’s picture

Assigned: a.milkovsky » Unassigned
Status: Active » Needs review

needs review. See the PR in description

fago’s picture

Status: Needs review » Needs work

has conflicts now.

a.milkovsky’s picture

Status: Needs work » Needs review

resolved

fago’s picture

Status: Needs review » Needs work

Reviewed it, a few issues are left though.

a.milkovsky’s picture

PR issues are answered.
Only few errors in Travis left. Like: Drupal\Component\Plugin\Exception\PluginNotFoundException: The "rules_entity_save" plugin does not exist.

a.milkovsky’s picture

Only one failure left:

There was 1 failure:
1) Drupal\Tests\rules\Integration\Engine\IntegrityCheckTest::testIntegrityCheck
Failed asserting that 1 matches expected 0.
/home/travis/build/fago/rules/tests/src/Integration/Engine/IntegrityCheckTest.php:48
tr’s picture

Is it really desirable, from a UI/end user standpoint, to have a dozen different "Save content", "Save comment", "Save taxonomy term" etc. actions showing up in the select list, rather than just one generic "Save entity" ?

I think we're getting to the point where there are far too many conditions to choose from, and far too many actions to choose from. So simplifying things by providing one "Save" action rather than one for each entity may be preferable.

tr’s picture

Assigned: Unassigned » fago
tr’s picture

Added #3255559: Re-label entity create action derivatives as one concrete example of where having a derivative action for each entity type causes confusion. In that case, the number of entities defined on the system resulted in a list of actions where most of the entries were derivatives. Those obscured the limited number of built-in Rules actions, and all those derivatives misled the original poster.

tr’s picture

Status: Needs work » Postponed
tr’s picture

Status: Postponed » Closed (won't fix)

Marking this as "won't fix" for the reasons explained above and in #3255559: Re-label entity create action derivatives