With all the UI classes added to rules\Core, the namespace has many classes now. I'd propose moving all UI related classes into rules\Ui\.. while keeping their name for easy findability in class lookups.

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Priority: Normal » Major

Setting to major as this would be an API change, thus should happen soon.

fago’s picture

fago
Primary language German
Location Vienna
commented

also, the TempStoreTrait should be moved into the UI namespace.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

ok, implemented that before we release the alpha: https://github.com/fago/rules/pull/429

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

now phpcs complains, strange
https://travis-ci.org/fago/rules/jobs/114226133

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Fixed

forgot to move the phpcs rule to the new namespace also, tests pass now!

-> Merged.

  • fago committed 17297cb on 8.x-3.x 
    Issue #2672816 by fago: Update namespace in RulesUiDefinition exception.
  • fago committed 3a7bd71 on 8.x-3.x
    Issue #2672816 by fago: Move UI related classes into a UI namespace.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.