Allow to run just specific types when running all tests

1. +++ b/core/scripts/run-tests.sh
   @@ -292,6 +297,8 @@ function simpletest_script_parse_args() {
   +    'types' => [],
   

   Missing --types documentation

2. +++ b/core/scripts/run-tests.sh
   @@ -894,7 +905,7 @@ function simpletest_script_get_test_list() {
   -      $groups = simpletest_test_get_all($args['module']);
   +      $groups = simpletest_test_get_all($args['module'], $args['types'], $args['exclude-types']);
   

   Why should the types only work with --module and --all? Also tbh I think we should only have --types and make it work in conjunction with --all.

+++ b/core/scripts/run-tests.sh
@@ -208,6 +208,11 @@ function simpletest_script_help() {
+              run-tests.sh --all --types=

I don't think the --all is required and the example needs to include what --types= should be and I guess it should give an example where it is multiple types.

Nice work @alexpott and @dawehner this looks ready to me.

+++ b/core/modules/simpletest/simpletest.module
@@ -506,8 +507,8 @@ function simpletest_log_read($test_id, $database_prefix, $test_class) {
+function simpletest_test_get_all($extension = NULL, array $types = []) {

Do we typehint array now?

Nice work @alexpott and @dawehner this looks ready to me.

+++ b/core/modules/simpletest/simpletest.module
@@ -506,8 +507,8 @@ function simpletest_log_read($test_id, $database_prefix, $test_class) {
+function simpletest_test_get_all($extension = NULL, array $types = []) {

Do we typehint array now?

Why not, its an array.

Given that we ran into array typehinting issue in #2664290: Remove array typehints from batch callbacks. I think we should re-consider typehinting as array here as well.

+++ b/core/lib/Drupal/Component/Utility/NestedArray.php
@@ -349,4 +349,26 @@ public static function mergeDeepArray(array $arrays, $preserve_integer_keys = FA
+    $array = is_callable($callable) ? array_filter($array, $callable) : array_filter($array);
+    foreach ($array as &$element) {

This means that after the filtering if we have any array element left apply filter on those. Either we should document it explicitly or we should use third param $before = TRUE to filter given array before or after the nested filtering.

For point 2 clarification

  public static function filter(array $array, callable $callable = NULL, $before = TRUE) {
    if ($before) {
     $array = is_callable($callable) ? array_filter($array, $callable) : array_filter($array);
    }
    foreach ($array as &$element) {
      if (is_array($element)) {
        $element = static::filter($element, $callable);
      }
    }
    if (!$before) {
     $array = is_callable($callable) ? array_filter($array, $callable) : array_filter($array);
    }

    return $array;
  }

After the discussion with @dawehner we agreed the point 1 is not valid here and expanding filter function is out of scope so this patch is ready imo.

+++ b/core/lib/Drupal/Component/Utility/NestedArray.php
@@ -349,4 +349,26 @@ public static function mergeDeepArray(array $arrays, $preserve_integer_keys = FA
+

+++ b/core/modules/simpletest/src/TestDiscovery.php
@@ -115,11 +138,11 @@ public function registerTestNamespaces() {
+   * @return array An array of tests keyed by the first
+   * @code

I think this is not a complete sentence?

Is there a list of all the --types that can be used?

run-test.sh doesn't work with an equal sign, and the capital 'T' in SimpleTest should be lowercased.

When testing the patch, I noticed that inputing an invalid type did not result in an error, we might want to have another class written to check if the type is valid.

On the DrupalCI side, since the types are being include and not excluded, we need to hardcode the types that are being tested, and those types will need to be updated everytime they are changed.

DCI will allow D.o to send over the types via the DCI_TestGroups parameter, but then d.o will need to know what they are.

putting this back to RTBC. Tests check out.

Committed 220e86d and pushed to 8.0.x, 8.1.x, and 8.2.x. Thanks!

diff --git a/core/lib/Drupal/Component/Utility/NestedArray.php b/core/lib/Drupal/Component/Utility/NestedArray.php
index 995211f..85b4bef 100644
--- a/core/lib/Drupal/Component/Utility/NestedArray.php
+++ b/core/lib/Drupal/Component/Utility/NestedArray.php
@@ -353,7 +353,7 @@ public static function mergeDeepArray(array $arrays, $preserve_integer_keys = FA
    * Filters a nested array recursively.
    *
    * @param array $array
-   *   The filtered nested array
+   *   The filtered nested array.
    * @param callable|NULL $callable
    *   The callable to apply for filtering.
    *
diff --git a/core/modules/simpletest/tests/src/Unit/TestInfoParsingTest.php b/core/modules/simpletest/tests/src/Unit/TestInfoParsingTest.php
index 21dfad3..fda12f1 100644
--- a/core/modules/simpletest/tests/src/Unit/TestInfoParsingTest.php
+++ b/core/modules/simpletest/tests/src/Unit/TestInfoParsingTest.php
@@ -314,7 +314,7 @@ public function testGetTestClasses() {
           'name' => 'Drupal\Tests\test_module\Functional\FunctionalExampleTest',
           'description' => 'Test description',
           'group' => 'example',
-          'type' => 'PHPUnit-Functional'
+          'type' => 'PHPUnit-Functional',
         ],
       ],
       'example2' => [
@@ -322,13 +322,13 @@ public function testGetTestClasses() {
           'name' => 'Drupal\Tests\test_module\Functional\FunctionalExampleTest2',
           'description' => 'Test description',
           'group' => 'example2',
-          'type' => 'PHPUnit-Functional'
+          'type' => 'PHPUnit-Functional',
         ],
         'Drupal\Tests\test_module\Kernel\KernelExampleTest3' => [
           'name' => 'Drupal\Tests\test_module\Kernel\KernelExampleTest3',
           'description' => 'Test description',
           'group' => 'example2',
-          'type' => 'PHPUnit-Kernel'
+          'type' => 'PHPUnit-Kernel',
         ],
       ],
     ], $result);
@@ -358,7 +358,7 @@ public function testGetTestClassesWithSelectedTypes() {
           'name' => 'Drupal\Tests\test_module\Kernel\KernelExampleTest3',
           'description' => 'Test description',
           'group' => 'example2',
-          'type' => 'PHPUnit-Kernel'
+          'type' => 'PHPUnit-Kernel',
         ],
       ],
     ], $result);

A few very minor code style nits fixed on commit.

The new DCI tag has been deployed that takes advantage of this new functionality.