Closed (fixed)
Project:
Drupal core
Version:
8.1.x-dev
Component:
big_pipe.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2016 at 13:10 UTC
Updated:
22 Mar 2016 at 02:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersComment #3
wim leersFabianx told me in chat:
So, let me investigate that.
Comment #4
wim leersI investigated #2510104: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future and why it went with
<script type="application/json">…</script>. It was based entirely on https://mathiasbynens.be/notes/json-dom-csp#script, which explicitly says:In the comments on that blog post, Nicolas Gallagher from Twitter says:
And, sure enough:
Conclusion: it's safe to proceed with this.
Comment #5
wim leersComment #6
wim leersComment #7
wim leersFix typos.
Comment #8
wim leersSmall clean-up/consistency.
Comment #9
wim leersBumping to major. We should ship Drupal 8.1 with BigPipe like this ASAP, because it's The Right Thing.
Comment #11
wim leersComment #12
fabianx commentedRTBC - Looks great to me, also nice cleanup. No concerns.
Comment #14
wim leersStraight reroll.
Comment #15
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!
Comment #17
wim leersAlso committed & pushed to the contrib module for Drupal 8.0: http://drupalcode.org/project/big_pipe.git/commit/1df7881