Problem/Motivation

The Adminimal theme defines a box-sizing that is so specific it overrides box-sizing for contrib elements such as Chosen. This breaks contrib css.

Proposed resolution

Either:

  1. 1. Remove the box-sizing declaration, as it currently does nothing
  2. 2. Make the box-sizing declaration less specific, so it does not override contrib css.

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 adminimal_theme-box_sizing_breaks_contrib_css-2668936-2.patch695 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new adminimal_theme-box_sizing_breaks_contrib_css-2668936-2.patch695 bytes

Attached patch implements solution #1: remove the box-sizing declaration altogether.

dmitryVL’s picture

dmitryVL commented

Looks good. Move to rtbc.

dmitryVL’s picture

dmitryVL commented
Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

RTBC++

joelstein’s picture

joelstein commented

RTBC +1. :)

jackniu’s picture

jackniu commented

Same issue, when it will merge to new version?

andrtroe’s picture

andrtroe commented
Assigned: Unassigned » andrtroe
Issue tags: +Adminimal Release 7-1.25

  • idebr authored d94f1fd on 7.x-1.x 
    Issue #2668936 by idebr, dmitryVL, joelpittet, joelstein, andrey....
andrtroe’s picture

andrtroe commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.