Coming from: #1851094: Module requires "simple" reference fields. We've documented this limitation for now, but it would be nice to remove it completely.

Let's create an issue for this so we don't lose site of it.

CommentFileSizeAuthor
#4 make_it_work_with_views-2667940-4.patch2.73 KBWorldFallz

Comments

WorldFallz created an issue. See original summary.

WorldFallz’s picture

WorldFallz commented
Issue summary: View changes
WorldFallz’s picture

WorldFallz commented
Status: Postponed » Active

I'm not sure this is an actual limitation as much as the current implementation.

field_info_bundles() is always run on the field instance settings form. We should be able to make that conditional on whether or not the er field type is simple or views based. Or simply ignore it for 'views' based er fields.

Then, 'views' based er fields should behave similarly to how 'simple' er fields with no bundle selected behave (count all references regardless of bundle).

WorldFallz’s picture

WorldFallz commented
Status: Active » Needs review
StatusFileSize
new make_it_work_with_views-2667940-4.patch2.73 KB

It definitely seems like the previous issue with "views" based er fields was actually an artifact of one of the other issues that were recently resolved.

I've been testing with "views" based er fields with no problems. I've tested with and without bundles selected and even with the same ER field set to 'base' on one bundle and 'views' on another. All seem fine. Attached is a patch that simply removes this limitation.

  • WorldFallz committed 4e30f92 on 7.x-1.x 
    Issue #2667940 by WorldFallz: make it work with "views" based...
WorldFallz’s picture

WorldFallz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.