Problem/Motivation

Follow-up from #2509722: "Error: missing help" in Views for Node fields without descriptions.

NodeViewsData has lots of t() calls, it could use $this->t() instead since EntityViewsData uses StringTranslationTrait.

Proposed resolution

Update NodeViewsData to use $this->t() instead of t().

Check other classes that extend EntityViewsData in core and make the same change if needed.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 remove_t_function_from_classes_extending_EntityViewsData-2667346-4.patch70.76 KBmohit_aghera
#2 remove_t_function_from_classes_extending_EntityViewsData-2667346-1.patch57.96 KBmohit_aghera

Comments

catch created an issue. See original summary.

mohit_aghera’s picture

mohit_aghera commented
Status: Active » Needs review
StatusFileSize
new remove_t_function_from_classes_extending_EntityViewsData-2667346-1.patch57.96 KB

Uploading basic patch with required change.

Status: Needs review » Needs work

The last submitted patch, 2: remove_t_function_from_classes_extending_EntityViewsData-2667346-1.patch, failed testing.

mohit_aghera’s picture

mohit_aghera commented
StatusFileSize
new remove_t_function_from_classes_extending_EntityViewsData-2667346-4.patch70.76 KB

By mistake used 8.0.x branch. Updating with latest patch with head from 8.1.x

mohit_aghera’s picture

mohit_aghera commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

There is no example left:

$ag " t\(" | grep "ViewsData.php"

Additional I reviewed the changes using git diff --color-words and all changes looked perfect

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

fwiw this removes 15% of the t() calls in core.

Committed/pushed to 8.1.x, thanks!

  • catch committed 55e3b42 on 8.1.x 
    Issue #2667346 by mohit_aghera: EntityViewsData extending classes should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.