Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
user interface text
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Feb 2016 at 21:26 UTC
Updated:
15 Sep 2016 at 07:08 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
felribeiro commentedComment #4
anul commentedApplied this Patch. It is a minor change and looks great.
Comment #5
xjmSo this is not the only reference to "admin theme" in our UI text. Most instances in the codebase are in assertions or code comments, but there are others in the UI:
There are far more references to "administration theme", so I think this change is correct. Let's fix any others as well, though. We do not need to change test assertion messages or code comments, but we should fix any user-facing strings in the same issue.
Thanks!
Comment #6
anul commentedAdding a new patch after fixing the points in #5 comment.
Comment #7
manjit.singhNot sure but i have find "admin theme" in whole codebase and found this in couple of other files as well (excluding comments n all). So Are we going to change these also ?
Here are some of the place where you can find the text that is i guess user facing.
Comment #8
hesnvabr commented@Manjit.Singh In comment #5 it is mentioned that we don't need to change in test assertion messages or code comments.Applied patch working fine and i think conditions are also fulfilled.
Comment #9
star-szrThis is a string change so to make it into 8.2.x needs to get in before RC.
Comment #11
xjmCommitted e94c581 and pushed to 8.2.x. Thanks!
Comment #15
hesnvabr commented