Issue
This is pretty minor, but I think it would be nice to use consistent terminology on the appearance page when referring to the administration theme. Right now we use both "administration theme" and "admin theme". I vote we standardize on "administration theme".

Proposed resolution

Update the text used next to the name of the currently active administration theme so that it reads "administration theme" and not "admin theme".

Comments

eojthebrave created an issue. See original summary.

felribeiro’s picture

Status: Active » Needs review
StatusFileSize
new433 bytes

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anul’s picture

Status: Needs review » Reviewed & tested by the community

Applied this Patch. It is a minor change and looks great.

xjm’s picture

Title: Use consistent terminology when referencing administration themes on appearance page » Use consistent terminology when referencing administration themes in the UI (not "admin theme")
Status: Reviewed & tested by the community » Needs work

So this is not the only reference to "admin theme" in our UI text. Most instances in the codebase are in assertions or code comments, but there are others in the UI:

[mandelbrot:drupal | Tue 15:58:07] $ grep -ri "admin theme" * | grep -v "//" | grep -vi "tests" | grep -v "*"
core/lib/Drupal/Core/Extension/ThemeInstaller.php:        throw new \InvalidArgumentException("The current admin theme $key cannot be uninstalled.");
core/modules/node/config/schema/node.schema.yml:      label: 'Use admin theme when editing or creating content'
core/modules/system/src/Controller/SystemController.php:        $theme->notes[] = $this->t('admin theme');
core/themes/seven/seven.info.yml:# 1. Copy the whole of Seven and rename it as your own admin theme. You

There are far more references to "administration theme", so I think this change is correct. Let's fix any others as well, though. We do not need to change test assertion messages or code comments, but we should fix any user-facing strings in the same issue.

Thanks!

anul’s picture

Status: Needs work » Needs review
StatusFileSize
new2.62 KB

Adding a new patch after fixing the points in #5 comment.

manjit.singh’s picture

Not sure but i have find "admin theme" in whole codebase and found this in couple of other files as well (excluding comments n all). So Are we going to change these also ?

Here are some of the place where you can find the text that is i guess user facing.

core/modules/block/src/Tests/BlockUiTest.php
core/modules/menu_link_content/src/Tests/MenuLinkContentTranslationUITest.php
core/modules/node/src/Tests/NodeTranslationUITest.php
core/modules/system/src/Tests/System/MainContentFallbackTest.php
core/modules/system/src/Tests/System/ThemeTest.php
core/profiles/standard/tests/src/Functional/StandardTest.php
core/tests/Drupal/KernelTests/Core/Theme/ThemeInstallerTest.php
hesnvabr’s picture

Status: Needs review » Reviewed & tested by the community

@Manjit.Singh In comment #5 it is mentioned that we don't need to change in test assertion messages or code comments.Applied patch working fine and i think conditions are also fulfilled.

star-szr’s picture

Issue tags: +rc deadline

This is a string change so to make it into 8.2.x needs to get in before RC.

  • xjm committed e94c581 on 8.2.x
    Issue #2667242 by Anul, felribeiro, eojthebrave, pranavbabbar: Use...
xjm’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.2.0

Committed e94c581 and pushed to 8.2.x. Thanks!

  • xjm committed e94c581 on 8.3.x
    Issue #2667242 by Anul, felribeiro, eojthebrave, pranavbabbar: Use...

  • xjm committed e94c581 on 8.3.x
    Issue #2667242 by Anul, felribeiro, eojthebrave, pranavbabbar: Use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hesnvabr’s picture