Blocks visibility section rendering issue in Firefox

Above mentioned issue has been fixed here:

Please ignore previous patch, this patch has full code.

Thanks.

I am not understanding why PHP 5.5 & MySQL 5.5 CI error is failing as it has no php code. I feel there is an issue with testbot.

Looks good to me.

@HimanshuPathak, Please add put detail comment. (Screenshot would be advantage).

Applied the patch and verified changes. Attaching screenshot.

Thanks!

+++ b/core/themes/stable/css/core/vertical-tabs.css
@@ -4,7 +4,7 @@
-  margin: 1em 0 1em 15em; /* LTR */
+  margin: 1em 0; /* LTR */

We can't change CSS in Stable in almost all cases - this defeats the purpose of providing a Stable backwards compatibility layer for frontend and theming work.

If the issue here is in Bartik we should probably fix it in Bartik however I think this should be retested in 8.1.x first before we do anything else. This issue sounds very much like a duplicate of #2541252: Replace the .region-content ul/ol selector with text-formatted to refactor code + fix visual bugs. It may not be but we should figure that out first.

Thanks @Cottser for providing your valuable feedback, I have added my code change to bartik block.css and also verified this issue is not duplicate of above mentioned issue.

Best,
Zeeshan

Before applying patch:

After applying patch:

Code looks good. Thanks @zeeshan_khan :)

Thanks, I spent some time looking at this and I think this is essentially a duplicate of #2541252: Replace the .region-content ul/ol selector with text-formatted to refactor code + fix visual bugs. The bug reported here is fixed in 8.1.x. Attaching screenshots of 8.0.x vs. 8.1.x.

There are some issues with the solution proposed here as well. The patch adds vertical tabs CSS to the blocks component which is not the right spot (maybe if it was specific to vertical tabs in blocks but it isn't) and it's also quite a generic selector for this case.

What is happening here is a specificity war which we don't want to continue - the region-content ul, .region-content ol selector is the real problem here and we need to address the root of the problem, not the symptoms. We can potentially address the root cause in 8.0.x in #2541252: Replace the .region-content ul/ol selector with text-formatted to refactor code + fix visual bugs.

8.0.x:

8.1.x: