Change reaction-rule config to save the event with settings

thanks, looks good - but:
- there are some test fails: https://travis-ci.org/fago/rules/jobs/109316083
- found a small coding style issue, see PR

left one minor comment in the PR and you need to merge in changes from 8.x-3.x to resolve the conflicts.

I think we should stop using arrays and use a class with named properties/methods to be more self documenting what is available and can be used for an event configuration.

While I agree with that, I don't see how we could do that right now? #2100549: Plugin factories needlessly restrict configuration to arrays is not resolved, and event plugin configuration depends on the event plugin anyway?

I see, you do not mean plugin config but $rule->events. I've commented on that over at https://github.com/fago/rules/pull/405/files#r53568608.

Looks good, we can do a follow-up for that.

tests failed now after merge

thx, merged.