I recently had to "theme" the output from this module/views plugin, but found it was extremely difficult given how hardcoded the majority of the output is.

While the patch I'm about to attach does refactor quite a bit and add a lot of new features, I was extremely careful to not break any existing options/logic. I also fix/added a lot of documentation around the code so it should be easy to follow along with the changes.

CommentFileSizeAuthor
#2 plugin_hardcodes_a_lot-2664344-2.patch27.95 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markcarver created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Needs review
FileSize
plugin_hardcodes_a_lot-2664344-2.patch27.95 KB
ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented

Thank you so much for the Patch! I appreciate it honestly.

I am going to be reviewing modules likely in about a week as I work through a backlog of module updates and regular work. I just wanted to let you know this module is squarely on my radar.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

My pleasure :D

It's an interesting module to say the least and I'm still trying to figure out how to get this output to show up in the exposed filters area. I will probably have to do something more on a custom level in the theme.

Also, please excuse my lack of tense and words above, I'm really tired lol

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented

I have put this in github prior to deployment here. It is branch 2664344

Can you check this out and make sure it is working as well for you? I am going to be doing some testing on this as well.

https://github.com/ElusiveMind/alpha_pagination/tree/2664344

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented

With the amount of re-factoring in this, I am thinking we should brand this as v2.0. It looks like it has potential to break a lot of 1.0 current workings.

I need to do more testing.

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented

What do you think about some default values and a sample style sheet for these?

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

With the amount of re-factoring in this, I am thinking we should brand this as v2.0. It looks like it has potential to break a lot of 1.0 current workings.

As I stated above, I refactored it in a way that prevented any BC breakage. However, the call is completely up to you. I just posted the patch in an effort to give themers better control of the output.

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented
Status: Needs review » Reviewed & tested by the community

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented

Going into 7.x-1.3

ElusiveMind’s picture

ElusiveMind CreditAttribution: ElusiveMind commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.