Problem/Motivation

In the INSTALL.txt file that ships with D8 core, there is a command given for moving core files from the download directory to the web server's document root:
mv drupal-x.y.z/* drupal-x.y.z/.htaccess drupal-x.y.z/.csslintrc drupal-x.y.z/.editorconfig drupal-x.y.z/.eslintignore drupal-x.y.z/.eslintrc /path/to/your/installation

This command misses the drupal-x.y.z/.gitattributes file.

Proposed resolution

Include the drupal-x.y.z/.gitattributes file in the list of files to mv.

Remaining tasks

Confirm that the .gitattributes file should be included in the mv command, review and commit.

CommentFileSizeAuthor
#2 mv_gitattributes_file_in_install_process-2663936-2.patch688 bytesmilodesc

Comments

milodesc created an issue. See original summary.

milodesc’s picture

milodesc
he/him
commented
StatusFileSize
new mv_gitattributes_file_in_install_process-2663936-2.patch688 bytes
milodesc’s picture

milodesc
he/him
commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Good catch. I think you are correct that it should be added, and the patch looks right to me. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d231a33 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 4dec44b on 8.1.x 
    Issue #2663936 by milodesc: Include .gitattributes file in list of core...

  • alexpott committed d231a33 on 8.0.x 
    Issue #2663936 by milodesc: Include .gitattributes file in list of core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.