CommentFileSizeAuthor
#2 2663746-2.patch999 bytestwistor

Comments

twistor created an issue. See original summary.

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new 2663746-2.patch999 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2663746-2.patch, failed testing.

twistor’s picture

twistor commented
Status: Needs work » Needs review
mustanggb’s picture

mustanggb commented
Status: Needs review » Reviewed & tested by the community

According to http://php.net/manual/en/migration70.incompatible.php this is the correct thing to do.

mikeytown2’s picture

mikeytown2 commented

Moving #2715695: PHP7 - Uniform Variable Syntax update issue, trigger.test:88 here

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +PHP 7.0 (duplicate)

Too bad there's no way of running tests against PHP 7 on drupalci..

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Correction - we *can* run core tests against PHP 7, just not contrib tests.

fabianx’s picture

fabianx commented

RTBC + 1 - will commit ASAP

fabianx’s picture

fabianx commented
Issue tags: +Pending Drupal 7 commit
stefan.r’s picture

stefan.r commented
Parent issue: » #2656548: Fully support PHP 7.0 in Drupal 7
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Committed to 7.x - thanks!

  • David_Rothstein committed 1a7642e on 7.x 
    Issue #2663746 by twistor, MustangGB: Array to string conversion in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.