We'd like to use mailjet as mailsystem at a site, but when adding it breaks site deployment:

MailJet to retrieve existing contact properties! Please try again later or contact MailJet!

That happens even everything is configured correctly.

CommentFileSizeAuthor
#4 module_breaks_site-2663328-4.patch992 byteshargobind
#2 d7_mailjet_sync.patch1.4 KBfago

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review
StatusFileSize
new d7_mailjet_sync.patch1.4 KB

Let's see whether this fixes the problem.

The patch adds a hidden variable mailjet_user_sync which allows to deactivate the user syncing feature as we only need the mailsystem. I suspect this to cause the issue, while we do not need that feature. I think in general it would be nice to split the module such that one can easily choose which part of the functionality is needed.

It should be noted, that the module totally violates Drupal coding standards and should be overhauled to confirm to Drupal standards.

fago’s picture

fago
Primary language German
Location Vienna
commented

created #2663332: Module violates Drupal coding standards

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
StatusFileSize
new module_breaks_site-2663328-4.patch992 bytes

Thanks @fago, this is a very valuable workaround for those who don't need user syncing and avoid the errors that appear with how things are now.

I have attached an updated patch against the latest 2.x-dev branch (and it applies cleanly to 2.10). It simplifies your code by adding the check to the actual sync functions instead of the drupal hooks. Please review so we can get this RTBC.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Title: Module breaks site deployment » Add ability to disable user information syncing
Status: Needs review » Reviewed & tested by the community

It's just really super convenient to be able to disable user information syncing feature.

Patch works correctly.

I also think that all features related to user syncing & campaign management should live in their own submodules.

mailjet plugins’s picture

mailjet plugins commented
Version: 7.x-2.x-dev » 7.x-2.11
Status: Reviewed & tested by the community » Fixed

Hello everyone,

Thanks for identifying this issue and providing a patch for it. We have merged it in the latest version of the plugin 7.x-2.11.

Best regards,
Mailjet team

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.