Just what the issue title says. There should be -- must be -- basic functional tests of Panelizer :) I took a stab at it and got a fair ways, although an assertion is failing for some strange reason. Which is why I'm setting this issue to Needs Work out of the gate -- details in the patch.

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

StatusFileSize
new2.94 KB

Whoops, screwed up my diffing 'cause I'm clumsy like that. THIS is the patch you're looking for.

damienmckenna’s picture

Status: Needs work » Needs review
dsnopek’s picture

StatusFileSize
new937 bytes

On my dev environment I've been unable to get this test to complete. In fact, it eats my whole dev VM. :-) It could be an issue locally with my setup, but I haven't been able to dig in too far yet.

Here's an interdiff for some debugging changes that I wanted to try, but never got a chance to.

dsnopek’s picture

StatusFileSize
new3.72 KB
new3.5 KB

When I retested this today - it didn't crash my VM! Yay!

Unfortunately, I wasn't able to figure out why the content block wasn't working. So, I just switched to using a custom block plugin. Tests are passing for me locally!

I'd really like to add another test method that configures a custom override as well (the current method does a default) so that we know both are working.

Status: Needs review » Needs work

The last submitted patch, 5: panelizer-functional-tests-2662578-5.patch, failed testing.

dsnopek’s picture

Bah! Test is failing because of #2664616: Use PanelsDisplayVariant->setPageTitle() from #2664614. Might need to revert that, and then commit it after a Panels release?

dsnopek’s picture

Status: Needs work » Needs review

Reverted that issue - let's test this again.

dsnopek’s picture

StatusFileSize
new4.76 KB
new5.12 KB

Tests actually passing now! Yay!

I attempted to implement to a new method that tests custom overrides as well, but I couldn't get it working. As to not hold up this issue, I'm going to create a new issue for that: #2669780: Add functional test of Nodes with custom overrides

And here is a new patch that just renames the test and test method to be more specific (so we can add the above mentioned test when it's ready).

Status: Needs review » Needs work

The last submitted patch, 9: panelizer-functional-tests-2662578-9.patch, failed testing.

dsnopek’s picture

Status: Needs work » Needs review
StatusFileSize
new3.79 KB

Giiiiit! :-) I messed up the last patch, although the interdiff is correct. Here is a better patch.

  • dsnopek committed bb194d4 on 8.x-3.x authored by phenaproxima
    Issue #2662578 by dsnopek, phenaproxima: Add basic functional tests
    
dsnopek’s picture

Status: Needs review » Fixed

Works, yay! Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.