Closed (fixed)
Project:
Panelizer (obsolete)
Version:
8.x-3.x-dev
Component:
Tests
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Feb 2016 at 13:51 UTC
Updated:
1 Mar 2016 at 15:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
phenaproximaWhoops, screwed up my diffing 'cause I'm clumsy like that. THIS is the patch you're looking for.
Comment #3
damienmckennaComment #4
dsnopekOn my dev environment I've been unable to get this test to complete. In fact, it eats my whole dev VM. :-) It could be an issue locally with my setup, but I haven't been able to dig in too far yet.
Here's an interdiff for some debugging changes that I wanted to try, but never got a chance to.
Comment #5
dsnopekWhen I retested this today - it didn't crash my VM! Yay!
Unfortunately, I wasn't able to figure out why the content block wasn't working. So, I just switched to using a custom block plugin. Tests are passing for me locally!
I'd really like to add another test method that configures a custom override as well (the current method does a default) so that we know both are working.
Comment #7
dsnopekBah! Test is failing because of #2664616: Use PanelsDisplayVariant->setPageTitle() from #2664614. Might need to revert that, and then commit it after a Panels release?
Comment #8
dsnopekReverted that issue - let's test this again.
Comment #9
dsnopekTests actually passing now! Yay!
I attempted to implement to a new method that tests custom overrides as well, but I couldn't get it working. As to not hold up this issue, I'm going to create a new issue for that: #2669780: Add functional test of Nodes with custom overrides
And here is a new patch that just renames the test and test method to be more specific (so we can add the above mentioned test when it's ready).
Comment #11
dsnopekGiiiiit! :-) I messed up the last patch, although the interdiff is correct. Here is a better patch.
Comment #13
dsnopekWorks, yay! Committed. :-)