The hijri month and week strings are not inside t() AND Drupal.t() functions so they are not available for translation in taarikh.js AND taarikh_api.module.

Attached patch put month names in t() AND Drupal.t() functions.

command to apply patch git apply --reject --whitespace=fix taarikh_hijri_month_names_t_function.patch

CommentFileSizeAuthor
#5 taarikh_hijri_month_names_t_function_0.patch4.41 KBmhmd
#2 taarikh_hijri_month_names_t_function.patch10.36 KBmhmd
taarikh_hijri_month_names_t_function.patch2.18 KBmhmd

Comments

mhmd created an issue. See original summary.

mhmd’s picture

mhmd commented
Title: let Hijri month name translatable » let Hijri month and week strings translatable
Issue summary: View changes
StatusFileSize
new taarikh_hijri_month_names_t_function.patch10.36 KB
hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review

Thank you for the patch. I am planning to take a look at this and commit it after DrupalCon Asia (or during).

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Needs work

Hi @mhmd, I am sorry it took me such a long time to come back to this issue. I checked the patch and see that the indentation has changed. Can you please reformat the changes as per earlier? You can check Drupal's coding standards here - https://www.drupal.org/docs/develop/standards/javascript/javascript-codi...

Thanks!

PS I am working on a D8 version of this module now. I hope to have something working by this week.

mhmd’s picture

mhmd commented
StatusFileSize
new taarikh_hijri_month_names_t_function_0.patch4.41 KB

Updated patch fixed identation

  • hussainweb committed b2fa853 on 7.x-1.x authored by mhmd 
    Issue #2660904 by mhmd, hussainweb: let Hijri month and week strings...
hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Fixed

Thanks!

The patch could not be applied because you seem to have created this based off your site's repository, not the module (I think that is why you had trouble applying the patch in the other issue). I fixed the patch and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.