A lot of new contributors bump into the placeholder issue on FF at least. The plugin adds some unwanted output in the strings when a placeholder exists in the original string.

Residue string: placeholder">

Please remove this :) It smells like a regexp issue. :)

Thank you.

CommentFileSizeAuthor
#2 @l10nfirefox-0.0.3.xpi_.txt30.24 KBizus
#2 l10n_glossary_tooltip-placeholder-2659454-2.patch48.69 KBizus

Comments

Artusamak created an issue. See original summary.

izus’s picture

izus commented
Status: Active » Needs review
StatusFileSize
new l10n_glossary_tooltip-placeholder-2659454-2.patch48.69 KB
new @l10nfirefox-0.0.3.xpi_.txt30.24 KB

Hi,

Thanks for reporting the issue.
Here is a new patch that corrects this.
Also there is a new .xpi to test the extension. (just rename it by deleting the .xpi)

Details of the issue:
Actually what was happening is that we have 'placeholder' in our glossary and the html for string in localize.drupal.org containes this : 'class="l10n-placeholder"', so it get replaced... :/

Thanks

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented

I don't know if it's because i'm banned from the french glossary site but i don't see the highlight anymore (even in the previous value).
I will be able to test again once someone unban my IP.

One other point, FF may be going to block unsigned extensions as mentioned here: https://support.mozilla.org/fr/kb/signature-modules-complementaires-fire... I don't know what are the reasons to keep an unsigned extension but it may be an issue very soon. Another advantage of the signed extension would be to benefit from the updates that we can't leverage at the moment.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Needs review » Fixed

Top! It works. Thank you.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Fixed » Reviewed & tested by the community

Sorry, i've been overexcited. This is RTBC until your release it on the glossary website.
And this is still very important: https://developer.mozilla.org/en-US/Add-ons/Distribution

izus’s picture

izus commented

Thanks Artusamak :)
about the signature, https://developer.mozilla.org/en-US/Add-ons/Distribution stands that one manner to do this is "submitting them to AMO", i am following this review process currently, and once it's done, i'll ping SebCorbin to update links in traduction.drupalfr.org

SebCorbin’s picture

SebCorbin commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to traduction.drupalfr.org.
Izus you have now the right to push patches to the repository :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.