Problem/Motivation

The minimal install profile carries a dependency on the dblog module. When you build your D8 site and export the core.extensions via CM, minimal is also a part of this export. This in turn means that disabling dblog in the future and importing an updated core.extensions will violate this dependency and issue an error like "Unable to install the Minimal module since it requires the Database Logging module."

Proposed resolution

Remove dblog as a dependency in the minimal install profile

Remaining tasks

Evaluate propsed resolution and patch.

User interface changes

Database Logging module will not be enabled when installing via Minimal install profile.

API changes

None

Comments

achton created an issue. See original summary.

achton’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal-minimal-dblog-remove.patch, failed testing.

andypost’s picture

Issue tags: +Configuration system, +Novice

Makes sense, just needs to fix test

alvar0hurtad0’s picture

In this patch the dependency module used in the test is chaged to "node"

andypost’s picture

Version: 8.0.x-dev » 8.1.x-dev
Issue tags: +Needs change record

features goes to 8.1 and CR needed

andypost’s picture

Saphyel’s picture

@andypost there is no documentation about which modules should be enabled in minimal atm. (In the code at least)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

I have no issue with not installing dblog in minimal and as this doesn't effect existing sites I see no reason not to do this in 8..x.x

alexpott’s picture

Component: configuration system » other
Category: Feature request » Task
Issue summary: View changes
Issue tags: -Configuration system

This is not an API change. Nor is it a feature. Nor is it part of the configuration system. There is no component that really fits this so going with "other".

This in turn means that disabling dblog in the future and importing an updated core.extensions will violate this dependency and issue an error like "Unable to install the Minimal module since it requires the Database Logging module."

I've tested this and none of that occurs.

andypost’s picture

Status: Needs review » Needs work

Still needs change record

+++ b/core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php
@@ -187,7 +187,7 @@ function testDependencyResolution() {
-    $dependency = 'dblog';
+    $dependency = 'node';

no reason to slowdown test with module that has a lot of dependencies
please use something slim like "action" module

alvar0hurtad0’s picture

Status: Needs work » Needs review
FileSize
1.05 KB
738 bytes

Here the changes on #12

Status: Needs review » Needs work

The last submitted patch, 13: do_not_require_dblog_as-2658864-13.patch, failed testing.

aburrows’s picture

Assigned: Unassigned » aburrows

Working on this at Drupalcon New Orleans

aburrows’s picture

Assigned: aburrows » Unassigned
alexpott’s picture

This in turn means that disabling dblog in the future and importing an updated core.extensions will violate this dependency and issue an error like "Unable to install the Minimal module since it requires the Database Logging module."

Dependencies of profile modules are not required so I'm not sure why we're seeing this. Can either the IS be updated or evidence of this behaviour provided?

aburrows’s picture

Assigned: Unassigned » aburrows
aburrows’s picture

Patch attached, removed the dblog from minimal.info.yml

Pradnya Pingat’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: do_not_require_dblog_as-2658864-19.patch, failed testing.

rajeshwari10’s picture

Assigned: aburrows » rajeshwari10
rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
1.02 KB

Deleted the dependency for db_log.

Status: Needs review » Needs work

The last submitted patch, 23: do_not_require_dblog_as-2658864-23.patch, failed testing.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
1.06 KB
1.02 KB

Adding patch and interdiff.
Thanks!!

markdorison’s picture

The patch removes dblog as a dependency but adds action, but I don't see any mention in the issue summary of why the latter is being done. +1 for an updated issue summary if I am missing something.

In the meantime, I am submitting a patch that depends on uninstalling block for the test and does not add a new dependency for the minimal profile.

dagmar’s picture

The patch removes dblog as a dependency but adds action, but I don't see any mention in the issue summary of why the latter is being done. +1 for an updated issue summary if I am missing something.

This was suggested on #12:

no reason to slowdown test with module that has a lot of dependencies please use something slim like "action" module
markdorison’s picture

@dagmar That makes sense with regard to the test, but then we are also adding a new dependency (action) for all site installs using the minimal profile. #26 uses block for the dependency test and does not add any additional dependencies to the minimal install profile.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

gambry’s picture

I don't understand the additional values this issue is trying to bring.

Without applying the patch (using 8.2.6), I have:

  1. Disabled dblog module
  2. Exported the configuration. Now dblog is not listed on core.exstension and dblog.settings entity conf is deleted
  3. Re-installed a Drupal instance, importing the configuration with config_installer with $settings['install_profile'] = 'minimal';

Minimal is the running profile, dblog is not installed, no error message during installation.

UPDATE: Same experience on importing the configuration without dblog into an instance running minimal, no errors.

Patch works and I'm happy to create the CR and RTBC but I'm not sure - as said above - what we are trying to achieve here.

Noemi’s picture

We test it and it works. The minimal profile has been installed without dblog.

#ddrome17 #hackaton

arturopanetta’s picture

Ok #ddrome17

dagmar’s picture

Status: Needs review » Needs work

The patch doesn't apply anymore.

markdorison’s picture

Status: Needs work » Needs review

Patch in #26 applies cleanly for me against the 8.4.x branch .

alexpott’s picture

No one has answered @gambry's question in #31. Install profile "dependencies" are not the same as module dependencies.