Problem/Motivation

In order for IWC to support hard and soft limit for image cropping we need to have some configuration in the crop type.

Proposed resolution

Add hard and soft limit to crop type.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 add_configuration_for-2657416-6.patch.patch4.48 KBthenchev
#6 interdiff.txt1.13 KBthenchev
#4 interdiff.txt2.52 KBthenchev
#4 add_configuration_for-2657416-4.patch4.4 KBthenchev
#2 add_configuration_for-2657416-2.patch4.38 KBthenchev

Comments

Denchev created an issue. See original summary.

thenchev’s picture

thenchev commented
Status: Active » Needs review
StatusFileSize
new add_configuration_for-2657416-2.patch4.38 KB
slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work 
  1. +++ b/src/Form/CropTypeForm.php
@@ -65,6 +65,51 @@ class CropTypeForm extends EntityForm {
+      '#description' => $this->t('Define the soft limit with and height. When
+      the user is trying to make a smaller selection then defined here a warning
+      is displayed.'),

    Don't break lines.

    I'd say something like "Define crop size soft limit. Warning will be displayed if crop smaller than that is selected." 

  2. +++ b/src/Form/CropTypeForm.php
@@ -65,6 +65,51 @@ class CropTypeForm extends EntityForm {
+      '#type' => 'textfield',

    Use number instead of textfield. Applies to others too. 

  3. +++ b/src/Form/CropTypeForm.php
@@ -65,6 +65,51 @@ class CropTypeForm extends EntityForm {
+      '#description' => $this->t('Define the hard limit with and height. User is
+      not allowed to make a smaller selection the defined here.'),

    Similar to above.

thenchev’s picture

thenchev commented
Status: Needs work » Needs review
StatusFileSize
new add_configuration_for-2657416-4.patch4.4 KB
new interdiff.txt2.52 KB
slashrsm’s picture

slashrsm commented

Let's add #min => 0 to configuration form number elements.

thenchev’s picture

thenchev commented
StatusFileSize
new interdiff.txt1.13 KB
new add_configuration_for-2657416-6.patch.patch4.48 KB

Added min.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed.

  • slashrsm committed 5ec7b07 on 8.x-1.x authored by Denchev 
    Issue #2657416 by Denchev, slashrsm: Add configuration for hard and soft...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.