ResponsiveImageFormatter should define dependencies to responsive image style entity

Looks great!

1. +++ b/core/modules/responsive_image/src/Tests/Update/ResponsiveImageUpdateTest.php
   @@ -0,0 +1,82 @@
   +    // avoid installation of configurations shipped in module.
   

   Nit: s/configurations/configuration/

2. +++ b/core/modules/responsive_image/tests/src/Kernel/ResponsiveImageIntegrationTest.php
   @@ -0,0 +1,77 @@
   +    // Check that the view display wa snot deleted.
   

   Nit: s/wa snot/was not/

8.0.x has now had its final release.

Shouldn't this be using the replacement image style if the image style gets deleted.

testing the issu

Let's test to see what is happening right now:

• Apply this patch in a feature branch
• On your local, for the article content type, set the image field to the responsive image formatter, and set the style to Narrow.
• Go to the responsive image style config and delete the Narrow style
• Go back to the article field display and check what the image formatter is now set to. Take a screenshot or two for bonus points.

Shouldn't this be using the replacement image style if the image style gets deleted.

No, because that would mean it's no longer a responsive image style. The fallback image style is specifically intended for the case of the browser not supporting responsive images. It is not okay to just make all images using a certain responsive image style use the same image style always (i.e. the fallback).

Patch no longer applies.

Thanks!

fail: [Other] Line 139 of core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php:
"Congratulations, you upgraded Drupal!" found

Random migrate fails strike again!

+++ b/core/modules/responsive_image/responsive_image.post_update.php
@@ -0,0 +1,28 @@
+    $entity_view_display->save();

we can do less here by only saving if the dependencies are different - see views_post_update_serializer_dependencies().... something like:

    $old_dependencies = $entity_view_display->getDependencies();
    $new_dependencies = $entity_view_display->calculateDependencies()->getDependencies();
    if ($old_dependencies !== $new_dependencies) {
      $entity_view_display->save();
    }

Re-roll patch @claudiu.cristea with resolve given solution in last comment #20.

1. +++ b/core/modules/responsive_image/responsive_image.post_update.php
   @@ -0,0 +1,32 @@
   +  array_walk($displays, function(EntityViewDisplayInterface $entity_view_display) {
   +    $old_dependencies = $entity_view_display->getDependencies();
   +    $new_dependencies = $entity_view_display->calculateDependencies()->getDependencies();
   +    if ($old_dependencies !== $new_dependencies) {
   +      $entity_view_display->save();
   +    }
   
   index b91ef18..ff91e68 100644
   --- a/core/modules/responsive_image/src/Plugin/Field/FieldFormatter/ResponsiveImageFormatter.php
   

   This is indeed a nice pattern!

2. +++ b/core/modules/responsive_image/src/Tests/Update/ResponsiveImageUpdateTest.php
   @@ -0,0 +1,82 @@
   +/**
   + * @file
   + * Contains \Drupal\responsive_image\Tests\Update\ResponsiveImageUpdateTest.
   + */
   
   +++ b/core/modules/responsive_image/tests/src/Kernel/ResponsiveImageIntegrationTest.php
   @@ -0,0 +1,77 @@
   +
   +/**
   + * @file
   + * Contains \Drupal\Tests\responsive_image\Kernel\ResponsiveImageIntegration.
   + */
   +
   

   Let's ensure to remove them right before the comment.

+++ b/core/modules/responsive_image/tests/src/Kernel/ResponsiveImageIntegrationTest.php
@@ -0,0 +1,77 @@
+    $this->assertFalse(array_key_exists('bar', $display->get('hidden')));
...
+    $this->assertTrue(array_key_exists('bar', $display->get('hidden')));

For future reference, you could leverage $this->assertArrayHasKey().

Back to RTBC. Thank you @claudiu.cristea

Committed/pushed to 8.2.x and cherry-picked to 8.1.x, thanks!