Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
* Check that referenced action and condition plugins are available
* Check the referenced Rules expression plugins are available
* Check that required modules are enabled
* Check that variable names only contain allowed characters in data selectors
* "The context %name may only be configured using a selector."
* "The context %name may not be configured using a selector."
* "The data type of the configured context does not match the context's %name requirement."
* "Missing configuration for required context %name."
Comments
Comment #2
klausiPR: https://github.com/fago/rules/pull/352
Comment #3
fagothanks, PR looks good I just added a minor note / suggestion.
I've not seen any coverage for the following points though? -> Setting needs work.
* Check that required modules are enabled
* "The data type of the configured context does not match the context's %name requirement."
So maybe, get this merged and open a follow-op or complete it here?
Also I'm wondering, is this the complete list compiled from what Drupal 7 does? We should make sure we do not miss anything by checking d7 integrity checks, but it seems you have done so already? :)
Comment #5
klausiRenamed the method and merged the PR.
Yes, those 2 checks you mentioned are still missing.
Yes, I looked through D7 and that were all I could identify. Added another for required contexts were the configuration is missing.
Let's continue in this issue with the remaining violations.
Comment #6
klausiContinuing at https://github.com/fago/rules/pull/357
Comment #7
fagoI think we also miss integrity checks in data processors. Just added the following comment:
Then, action & condition plugins must be able to complete an integrity check for their configuration also. Then, we need to implement this for the component integration such that we can check a used component exists and all required contexts are configured.
Comment #8
klausiData processors: yes, let's open a dedicated follow-up issue for that.
Same for actions and condition plugins ==> follow-up.
Required contexts is now covered in the PR.
Comment #9
klausiFollow-up for data processors: #2658940: Integrity check for data processor plugins
Comment #10
klausiFollow-up for actions and conditions: #2658944: Integrity check on action and condition plugins.
@fago: can you edit the issue summary there? I don't have an example for a use case.
Comment #12
klausimerged.
I think we are covered with the follow-up issues linked above.