Doesn't appear to be used.

CommentFileSizeAuthor
#6 remove_plugininterface-2654628-6.patch503 bytesgnuget
removePluginInterface.patch522 byteslokapujya

Comments

lokapujya created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Version: 8.0.x-dev » 8.1.x-dev

Indeed, nothing is using this interface, so removing this should not be an API break?

novitsh’s picture

novitsh commented
Status: Needs review » Reviewed & tested by the community

In my best opinion, it's a good to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

I think this should be deprecated and marked for removal in D9 and not removed in D8. I've asked the other committers for their opinion.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
gnuget’s picture

gnuget
Primary language Spanish
commented
Title: Remove PluginInterface » Deprecate PluginInterface
Status: Needs work » Needs review
StatusFileSize
new remove_plugininterface-2654628-6.patch503 bytes

Deprecated instead of deleted.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Needs change record

Great Thanks! This is accommodating #4. it can perfectly to to RTBC
This needs a change notice as well.

Status: Needs review » Needs work

The last submitted patch, 6: remove_plugininterface-2654628-6.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review

setting to N/R random failures due to UpdatePathTestBase schema missing issues & FieldHandlersUpdateTest

Status: Needs review » Needs work

The last submitted patch, 6: remove_plugininterface-2654628-6.patch, failed testing.

The last submitted patch, 6: remove_plugininterface-2654628-6.patch, failed testing.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Needs review

I re-run the tests and this time they passed. marking this as needs review.

novitsh’s picture

novitsh commented
Status: Needs review » Reviewed & tested by the community

Follows remark in #4. Good to go for me. RTBC?

gnuget’s picture

gnuget
Primary language Spanish
commented

Great Thanks! This is accommodating #4. it can perfectly to to RTBC
This needs a change notice as well.

does It really need one? I mean, no one is using this interface, remove/deprecate it won't affect any API.

  • catch committed a4bc5fb on 8.3.x 
    Issue #2654628 by gnuget, lokapujya: Deprecate PluginInterface
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.1.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x, thanks!

Agreed on no change notice. As far as we know this is dead code, change notices should be used for things we actually want to notify people about.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

As far as we know this is dead code, change notices should be used for things we actually want to notify people about.

Okay, yup that makes sense

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.