Problem/Motivation

Scenario: Clear views cache.

Clearing cache I noticed a lot of function calls to views_include() and intern to ctools_include() which stores an internal static with require_once for performance.

require_once is a bit slower than include_once and this is an unnecessary layer of abstraction.

Proposed resolution

Replace and deprecate views_include() with include_once()

Helps with performance (see screenshot) and unnecessary abstraction (IMO).

CommentFileSizeAuthor
#2 replace_views_include-2653214-2.patch489 bytesjoelpittet
XHProf__Hierarchical_Profiler_Report.png169.4 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new replace_views_include-2653214-2.patch489 bytes

Here's the patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Saved me about 8 ms on a different site.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

It helps.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: +minor version target

joelpittet has done some great work here. Adding the 'minor version target' tag.
Please include this for 7.x-3.17

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2760405: Reduce the calls to the same t() in views_fetch_fields()

These other performance fixes all play nice together. I recommend all of them for 7.x-3.17 please and thanks.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2760419: get_option() micro optimization, +#2653266: Avoid excess t() calls in field_views_field_default_views_data()
dsutter’s picture

dsutter commented

RTBC+ patch #2

gdaw’s picture

gdaw commented

Performance boost confirmed.

RTBC for patch #2

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2903944: Plan for Views 7.x-3.19 release
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Looks good for 3.19! I assume this is comming soon?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Slowly..

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.