I've found 1 error in Drupal5 (missing @code)
http://api.drupal.org/api/function/drupal_execute/5

and 2 errors in Drupal 6
(same as previous)
http://api.drupal.org/api/function/drupal_execute
(missing @code)
http://api.drupal.org/api/function/actions_list/6

CommentFileSizeAuthor
#10 265265_D6.patch1.48 KBjhodgdon
#7 265265.patch780 bytesjhodgdon
D6-form.inc_.patch637 bytesneochief
D6-actions.inc_.patch599 bytesneochief
D5-form.inc_.patch590 bytesneochief
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Project: Documentation » Drupal core
Version: » 6.x-dev
Component: Documentation in CVS » documentation

wrong issue queue.

neochief’s picture

neochief CreditAttribution: neochief commented

Too bad that it wasn't got to 5.8/6.3 :(

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

I am testing patches today... The D6 patches have file paths that are specific to your computer, so they do not apply easily...

But other than that, they look good.

neochief’s picture

neochief CreditAttribution: neochief commented

Yeah, year ago I wasn't so good with making patches as today :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 7.x-dev

Let's get this to Drupal 7 first to avoid introducing a regression. Also, it would be best to roll patches into one per version, not one per file per version.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Reviewed & tested by the community
FileSize
265265.patch780 bytes

No fix is needed for actions.inc in Drupal 7 -- http://api.drupal.org/api/function/actions_list/7 -- already has @code around the example.

So here is a patch for form.inc , same content as above patch for D6.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Incidentally the function doc patched in D7 is http://api.drupal.org/api/function/drupal_form_submit/7 (example was in drupal_execute() in D6)

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD, moving version to Drupal 6. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
FileSize
265265_D6.patch1.48 KB

Here's a one-file well-formatted (I hope) patch for D6, incorporating the two patches above. Shouldn't need further review, I would think...

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks, committed to Drupal 6. Looks like there was also some suggested fixes for Drupal 5.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Patch (to be ported) » Closed (won't fix)

7.0 is out tomorrow, 5.x is obsolete, won't fix, sorry.