Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Around line 270 of file core/modules/migrate/src/MigrateExecutable.php, there is the code statement:
unset($sourceValues, $destinationValues);
$this->sourceValues and $this->destinationValues are members of the class declared in that file. $sourceValues and $destinationValues variables are not otherwise used in the file. Hence, the logic of this line probably should be changed to reference the class members and tests added.
This was discovered as part of #2624640: Fixes to docs and code style for migrate/src/*.php files and was requested to be broken out into its own issue.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2645164-4-7.txt | 739 bytes | kekkis |
#7 | 2645164-7.patch | 1.15 KB | kekkis |
#4 | 2645164-4.patch | 1.15 KB | quietone |
|
Comments
Comment #4
quietone CreditAttribution: quietone as a volunteer commentedCan't find any usages of $sourceValues or $destinationValues.
Lets remove them.
Comment #5
heddnI cannot find any mentions of these variables either. And it isn't in drush's version either.
Comment #7
kekkisRerolled against 8.2.x after new commits there on Oct 21. As you can see in the interdiff, only line offsets have changed. Also issuing retests as it seems the "fail" was due to something else than failing tests per se.
Comment #8
heddnThis is ready again.
Comment #9
alexpottCommitted and pushed 6695406 to 8.3.x and 9586424 to 8.2.x. Thanks!