Around line 270 of file core/modules/migrate/src/MigrateExecutable.php, there is the code statement:

  unset($sourceValues, $destinationValues);

$this->sourceValues and $this->destinationValues are members of the class declared in that file. $sourceValues and $destinationValues variables are not otherwise used in the file. Hence, the logic of this line probably should be changed to reference the class members and tests added.

This was discovered as part of #2624640: Fixes to docs and code style for migrate/src/*.php files and was requested to be broken out into its own issue.

CommentFileSizeAuthor
#7 interdiff-2645164-4-7.txt739 byteskekkis
#7 2645164-7.patch1.15 KBkekkis
#4 2645164-4.patch1.15 KBquietone

Comments

Lars Toomre created an issue. See original summary.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2645164-4.patch1.15 KB

Can't find any usages of $sourceValues or $destinationValues. 

v@dev0 {/opt/sites/d8} (8.2.x)$ grep -r destinationValues core
v@dev0 {/opt/sites/d8} (8.2.x)$ grep -r SourceValues core
v@dev0 {/opt/sites/d8} (8.2.x)$

Lets remove them.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

I cannot find any mentions of these variables either. And it isn't in drush's version either.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2645164-4.patch, failed testing.

kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
commented
Status: Needs work » Needs review
StatusFileSize
new 2645164-7.patch1.15 KB
new interdiff-2645164-4-7.txt739 bytes

Rerolled against 8.2.x after new commits there on Oct 21. As you can see in the interdiff, only line offsets have changed. Also issuing retests as it seems the "fail" was due to something else than failing tests per se.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

This is ready again.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6695406 to 8.3.x and 9586424 to 8.2.x. Thanks!

  • alexpott committed 6695406 on 8.3.x 
    Issue #2645164 by kekkis, quietone, heddn, Lars Toomre: Fix use of $...

  • alexpott committed 9586424 on 8.2.x 
    Issue #2645164 by kekkis, quietone, heddn, Lars Toomre: Fix use of $...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.