Problem/Motivation

File attachment not working.

Steps to replicate:

  • Download and install latest dev version of the module
  • Go to configuration page of this module
  • Select "Normal AJAX" option in "Choose Polling Method"
  • Make sure "Enable File Attachment" is selected "Yes"
  • Save configuration

When I am chatting with a user not attach option is available.

Proposed resolution

After checking the code, I saw that by default this module does not provides support for file attachment, unless you use iFlyChat service. So either:

  • Hide that file attachment option by default
  • Enable support for file attachment even if third party service is not selected.

Remaining tasks

  • Provide Drush integration for downloading jQuery fileupload plugin library.
  • Show error message if file fails to upload

User interface changes

Apart from file attachment option in admin UI, also add option for file types.

API changes

drupalchat_sendfile() added that sends attachments via AJAX.

Data model changes

N/A

CommentFileSizeAuthor
#8 file_attachment_not-2644492-8.patch44.63 KBsubhojit777
#7 file_attachment_not-2644492-7.patch44.44 KBsubhojit777
#4 file_attachment_not-2644492-4.patch44.33 KBsubhojit777

Comments

subhojit777 created an issue. See original summary.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Version: 7.x-1.7 » 7.x-1.x-dev
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Issue summary: View changes
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Issue summary: View changes
Status: Active » Needs work
StatusFileSize
new file_attachment_not-2644492-4.patch44.33 KB
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Issue summary: View changes
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Issue summary: View changes
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
StatusFileSize
new file_attachment_not-2644492-7.patch44.44 KB

Bug fix.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Issue summary: View changes
StatusFileSize
new file_attachment_not-2644492-8.patch44.63 KB
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

The 7.x-1.x branch is now not supported. Any bug will be fixed in the 7.x-2.x branch, until Drupal 7.x is not supported. It is probably better to focus on resolving bugs in the Drupal 8 branch and make it compatible with Drupal 9 or Drupal 10.