Follow-up to #2637304: Add missing typehints in EntityAutocomplete.

FormElementInterface::valueCallback() is type hinted as an array in the doc block, but not in the function definition. We should therefor also type hint the definition.

CommentFileSizeAuthor
#2 add_missing_typehint-2643890-2.patch14.53 KBlegolasbo

Comments

legolasbo created an issue. See original summary.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Active » Needs review
StatusFileSize
new add_missing_typehint-2643890-2.patch14.53 KB

Attached patch adds the missing type hint to the interface's method and every method implementing it.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Issue tags: +BC break

This is a BC break, because it will cause errors for any class that implements the interface and that has not been updated yet, which, with this patch, effectively means contrib will experience issues with this change.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 8.0.x-dev » 9.x-dev
Status: Needs review » Active
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Component: documentation » forms system

This is not a docs issue, with this patch, in any case.

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.x-dev » 8.3.x-dev
Issue tags: -BC break

We could add a new interface, with a new method, with the type-hint.

When calling for valueCallback - check for the new interface and call the new method instead.

Have every core implementation implement this.

So moving back to 8.x to see how doable that is.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Minor

I don't think this is worth doing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Status: Active » Closed (duplicate)

Thanks for the patch. However, we have a number of issues dealing with coding standards fixes and the community has decided that the best way to approach this is by fixing a rule at a time, rather than a file at a time. See #2571965: [meta] Fix PHP coding standards in core, stage 1 for the meta issue where this effort is being organized,

The changes here have been moved to #3107000: Fix Drupal.Commenting.FunctionComment.TypeHintMissing, Credit applied over ther.

Closing this as a duplicate.