Problem/Motivation

In dialog.css the background-image: url(loading-small.gif); is invalid. This files does not exists in the CSS folder.

Proposed resolution

Fix the path.

Remaining tasks

User interface changes

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 Issue-2643636-by-hass-dialogcss-ajaxprogressthrobber.patch772 byteshass

Comments

hass created an issue. See original summary.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new Issue-2643636-by-hass-dialogcss-ajaxprogressthrobber.patch772 bytes
chrisfree’s picture

chrisfree commented
Status: Needs review » Reviewed & tested by the community

This patch looks good to my eyes. It now matches what is done in the Seven theme.

I was curious where else this image was being used and found that there are actually two versions of it. One found at: core/misc/loading-small.gif and one found at core/themes/stable/images/core/loading-small.gif.

I'm not familiar enough with the history here, but my guess is that there is a good reason for them both to exist and be duplicates. Since this replicates exactly the way that the Seven theme handles, I'd say this looks ready to move to RTBC.

hass’s picture

hass commented

Maybe we need to change stable for consistency, too? I have no idea about these history, too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 072943c and pushed to 8.0.x and 8.1.x. Thanks!

The stable one exists so we can potentially change the one in core.

  • alexpott committed f290489 on 8.1.x 
    Issue #2643636 by hass: dialog.css: ajax-progress-throbber URL is...

  • alexpott committed 072943c on 
    Issue #2643636 by hass: dialog.css: ajax-progress-throbber URL is...
chrisfree’s picture

chrisfree commented

@alexpott -- ahh, that's what I figured. Thanks for clearing it up!

hass’s picture

hass commented

Let's follow up with #2642362: Animation of throbber-active.gif image is broken now and replace both throbber files with the animated ones. I have no idea how to make a binary patch with eclipse myself.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.