Classifying this as a bug because it's a regression from D7 where you could filter on tags.

Currently the views overview page only filters by name and description. This makes the tag column pretty pointless (and the whole option to tag a view in general).

Steps to reproduce:
- Go to admin/structure/views
- Search for 'default'

expected result: The views tagged with 'default' show up
actual result: no views show up

CommentFileSizeAuthor
#7 interdiff.txt2.27 KBdawehner
#7 2638410-7.patch3.53 KBdawehner
#5 2638410-5.patch1.49 KBdawehner
#2 views_filter_by_tag-2638410-2.patch1.36 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new views_filter_by_tag-2638410-2.patch1.36 KB

This did the trick for me with manual testing.

Amruta_Nadgouda’s picture

Amruta_Nadgouda commented

Looks good. Working now :)

Amruta_Nadgouda’s picture

Amruta_Nadgouda commented
Assigned: Unassigned » Amruta_Nadgouda
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented
Assigned: Amruta_Nadgouda » Unassigned
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2638410-5.patch1.49 KB

a) We should not change the string, this is affected by the string freeze
b) IMHO we should use a data-drupal-selector attribute instead of the css class.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work

5a) fair enough.

5b) 

+++ b/core/modules/views_ui/js/views_ui.listing.js
@@ -30,7 +30,7 @@
-          var $sources = $row.find('.views-table-filter-text-source');
+          var $sources = $row.find('[data-drupal-selector="views-table-filter-text-source"]');

yeah, much better, but then we need to change this in views-ui-view-info.html.twig too. And in the 'Source' comment for Drupal.behaviors.viewTableFilterByText.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2638410-7.patch3.53 KB
new interdiff.txt2.27 KB

Good point @Lendude

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Manually tested this. With the patch applied I was able to search and find strings in :
- View title
- Machine name
- Description
- Tag

This looks ready to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 2638410-7.patch, failed testing.

The last submitted patch, 7: 2638410-7.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Reviewed & tested by the community

testbot hickup

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed 89c6fb8 on 8.1.x 
    Issue #2638410 by dawehner, Lendude: Views overview page doesn't filter...

  • catch committed 2f525c2 on 8.0.x 
    Issue #2638410 by dawehner, Lendude: Views overview page doesn't filter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.