Add node argument validator: title to id

So I think this is a good idea, but I worry that it'll generate a lot of negative feedback:

1) nodes with the same title
2) nodes with titles that contain non URL-safe characters

I'll think on this one.

Hi,
I added your patch and it is working well. As for duplicate titles it seems that auto node title creates unique paths for two nodes with the same title. It would therefore be possible to add the above code with the modification that it translates via the url path of pathauto instead.

Just an idea.

How did you do the things in #4 without the use of the title, please expand on it, I don't mind using a method which is safer.

I stumbled over your patch and applied it to my current project. But it didnt work.

My setup:
* 2 node types (A,B)
* node B contains a CCK field node reference to A
* pathauto of node B : [field_ref_descr_gi-title]/[title-raw].html which results to: <title-of-A>/<title-of-B>.html

My assumption: Since the argument is the converted and URL-usable title, it does'nt match the real title of the node.
(ref. line 6 of your code above)

my quick solution was to modify your patch as follows:

      case 'convert':
        if($types) {
/*          $and = " AND type IN ('" . implode("', '", $types) . "')"; */
        }
        $argumentSplitt = explode (".", $argument );
        $alias = db_fetch_object(db_query("SELECT * from {url_alias} WHERE dst = '%s.html'", $argumentSplitt));
        if (!$alias) {
          return FALSE;
        }
        $srcSplitt = explode ("/", $alias->src );
        $node = db_fetch_object(db_query("SELECT * from {node} WHERE nid = %s", $srcSplitt['1']));
        if(!$node) {
          return FALSE;
        }
        if (!empty($this->argument->options['validate_argument_node_access'])) {
          if (!node_access('view', $node)) {
            return FALSE;
          }
        }
        $this->argument->validated_title = $node->title;
        $this->argument->argument = $node->nid;
        return TRUE;

I know this is a quick and dirty hack, but I want to share it maybe it can be used for further development.
I wanted to dig deeper, but time's running out before Christmas (everyone want's his/her project finished)

Need an actual patch to really review this. Also this issue is very old.

I am trying to do this exact same thing. I am making a photo gallery where the gallery is a content type "gallery" and the individual pictures are content type "picture" with a node reference CCK field pointing the the gallery node they are part of. I am trying to create a new tab on the gallery page to allow the re-ordering of the pictures (using the weight module), but because I am using pathauto to make my URLs nice I am running into issues. My gallery paths are gallery/[gallery title], and no matter what I try I cannot get the page view (with menu tab path of gallery/%/arrange) to show up. If I navigate to gallery/[node ID number]/arrange the view shows, but I cannot get it to work with the url alias.

Sorry if my description is unclear, let me know and I will try to describe what I am doing better.

Any help is appreciated, thanks.

~orbmantell

Here is a patch that does what the OP's code desired, and a little more, allowing for use of Node: Title (or another field) as well.

When used as an argument against node title, this patch supports urls with or without spaces when used along with the "Transform spaces to dashes in URL" option. This mirrors how it already works without this argument validator, but adds a properly formatted title as well as offering the rest of the validation features.

As the Transform option is not available for the nid field, you can only use exact (more or less) title matches.

I'm placing this patch here in the hopes that someone else may think further on the subject.

From my perspective this clearly needs more work.

if ($this->argument->options['field'] == 'nid') {
+	        $this->argument->argument = $node->nid;
+        } else {
+                $this->argument->argument = $node->title;
+        }

This is undrupal-ish codestyle, sorry.

My most sincere apologies. Can you point me to some drupalish codestyle of that nature? I would be happy to modify it.

Edit: I noted the exceptionally poor indenting.. not sure where I was at that moment. If it was just the indenting, I'll gladly upload a fixed version. If it was something about the actual code content of the conditional statement (non-formatting) I'd like to understand.

a identing and b)

if {
}
else {
}

Understood and fixed + a little more cleanup, thank you for pointing that out.

+++ modules/node/views_plugin_argument_validate_node.inc	21 Jul 2010 20:50:23 -0000
@@ -117,6 +118,35 @@ class views_plugin_argument_validate_nod
+        if($types) {

additional this should be if () {

+++ modules/node/views_plugin_argument_validate_node.inc	21 Jul 2010 20:50:23 -0000
@@ -117,6 +118,35 @@ class views_plugin_argument_validate_nod
+        $node = db_fetch_object(db_query("SELECT * from {node} WHERE title = '%s'$and", $argument));

FROM

+++ modules/node/views_plugin_argument_validate_node.inc	21 Jul 2010 20:50:23 -0000
@@ -117,6 +118,35 @@ class views_plugin_argument_validate_nod
+        if(!$node) {

, too

Powered by Dreditor.

Sorry

Thanks again, and sorry for that. Fixes made.

Has there been any kind of update for this? this is a feature I currently need for views. I need the user to be able to enter the nodes title (from a node reference field) rather than the node id.

Hi luckysmack, I doubt we will see this particular ticket progress. I've worked this idea out a number of times, and like merlinofchaos originally said, there are just too many issues with using node titles in this way.

You might look at the node reference field issue from a different angle. There might be a way to design a node reference field that could allow a search by title, display those nodes along with specific node numbers, and allow the user to choose from them somehow. It would still have to store the node id as the reference.