simple_field_formatter_field_formatter_settings_summary_alter() is not preserving existing summary info.

CommentFileSizeAuthor
#6 simple_field_formatter-preserve-existing-summary-2632624-4.patch5.88 KBmfernea
#4 simple_field_formatter-preserve-existing-summary-2632624-3.patch6.24 KBsoyarma
#2 simple_field_formatter-preserve-existing-summary-2632624-2.patch3.93 KBmfernea

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea commented
Status: Active » Needs review
StatusFileSize
new simple_field_formatter-preserve-existing-summary-2632624-2.patch3.93 KB

Here is the patch along with some coding standards related improvements.

mfernea’s picture

mfernea commented
Assigned: mfernea » Unassigned
soyarma’s picture

soyarma commented
StatusFileSize
new simple_field_formatter-preserve-existing-summary-2632624-3.patch6.24 KB

This patch has better formatting in that it doesn't show items unless they're set. It also sets each item as its own translatable string.

Status: Needs review » Needs work

The last submitted patch, 4: simple_field_formatter-preserve-existing-summary-2632624-3.patch, failed testing.

mfernea’s picture

mfernea commented
Status: Needs work » Needs review
StatusFileSize
new simple_field_formatter-preserve-existing-summary-2632624-4.patch5.88 KB

+1 for the modifications from #4. Since the translatable strings were changed, when installing the patched version, the translations need to be updated.
I only recreated the patch in the correct format.

Status: Needs review » Needs work

The last submitted patch, 6: simple_field_formatter-preserve-existing-summary-2632624-4.patch, failed testing.

  • mfernea authored c4d0337 on 7.x-2.x 
    Issue #2632624 by mfernea, soyarma: Preserve existing summary
technikh’s picture

technikh commented
Status: Needs work » Fixed

Pushed to dev branch. Thanks for the patch mfernea & soyarma

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.