While the documentation for SearchApiQueryInterface::execute() explicitly states that the returned results always have to have both the 'result count' and 'results' keys set, there is actually a code path in our search() method which results in an empty results array. Even though unlikely to cause any errors (I'd say), we should still fix it.

CommentFileSizeAuthor
#2 2632426-2--skipped_result_count_results_array--tests_only.patch857 bytesdrunken monkey
#2 2632426-2--skipped_result_count_results_array.patch1.99 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Active » Needs review
FileSize
2632426-2--skipped_result_count_results_array.patch1.99 KB
2632426-2--skipped_result_count_results_array--tests_only.patch857 bytes

The attached patch should fix this, and even contains a test.

Status: Needs review » Needs work

The last submitted patch, 2: 2632426-2--skipped_result_count_results_array--tests_only.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs work » Fixed

Committed.

  • drunken monkey committed 5dabfea on 7.x-1.x 
    Issue #2632426 by drunken monkey: Fixed "results" key sometimes missing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.