Closed (fixed)
Project:
Transliteration
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Dec 2015 at 10:02 UTC
Updated:
1 Jan 2020 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ouiliam commentedI don't know if this is relevant, but there's a free translit extension here:
https://chrome.google.com/webstore/detail/arabeasy-view-arabic-web/endio...
Comment #3
drunken monkeyA client of mine ran into the same problem. I don’t speak Arabic at all, but I noticed that the transliteration for Drupal 7 and Drupal 8 differ for certain Arabic inputs:
Drupal 7:
Drupal 8:
The simplest fix for this problem would seem to just copy over Drupal 8’s mapping for the affected code block (x06). As said, I don’t speak any Arabic, but based on the feedback from my client it seems Drupal 8 got it right in this case, while this module doesn’t quite work for Arabic in all cases.
Patch attached, simply copy-pasting Drupal 8 Core’s
core/lib/Drupal/Component/Transliteration/data/x06.phpmapping to this module. Would be great if this could be committed! (You can easily check it’s just D8’s mapping, so even if you don’t speak Arabic yourself you can be confident that the mapping makes sense.)Of course, testing by actual Arabic speakers would also be great!
Comment #4
izus commentedHi,
tested #3 and it looks better indeed
Thanks
Comment #5
amir simantov commentedThanks guys for the patch and testing. Can this patch go into the module?
Comment #6
renatog commentedComment #8
renatog commentedCommitted to the dev branch.
Thank you all by contribution