Currently the library loads cropper.min.js and cropper.min.css directly from the root of the library folder. E.g: /libraries/cropper/cropper.min.js. Since Cropper itself has a different folder structure, we should load the files form a dist subfolder. E.g:/libraries/cropper/dist/cropper.min.js
Here is the Croppper repository: https://github.com/fengyuanchen/cropper
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | fix_cropper_library-2631676-7-interdiff.txt | 939 bytes | sasanikolic |
| #7 | fix_cropper_library-2631676-7.patch | 1.61 KB | sasanikolic |
| #3 | fix_cropper_library-2631676-3.patch | 1.65 KB | sasanikolic |
Comments
Comment #2
sasanikolic commentedComment #3
sasanikolic commentedNot sure if too much hardcoding?
Comment #4
luksakWell,
/libraries/cropper/dist/is too hardcoded. It could also be/sites/EXAMPLE/libraries/cropper/dist/, right?Comment #5
sasanikolic commentedRight. Should we drop the hardcoded path from the error message and point the user to read the readme file (where we will explain how to properly set up the library)?
Comment #6
luksakYes, that would be better.
Comment #7
sasanikolic commentedOk, so if the library module is enabled, we get the correct path (either in
/libraries/cropper/distor in/sites/defaultorXYZorall/libraries/cropper/dist).Comment #9
woprrr commentedPerfect :) Thanks for your jobs guys :)