CommentFileSizeAuthor
#15 BottomRightCornerIssue.png7.63 KBbjlewis2
#10 sshot-tokentree-2.png24.58 KBhussainweb
#10 2630374-10.patch919 byteshussainweb
#8 sshot-inner-div-shadow.png17.9 KBhussainweb
#5 2630374-5.patch888 byteshussainweb
#5 sshot-token-tree.png28.14 KBhussainweb
#4 sshot-block.png53.07 KBhussainweb
#2 Border and Shadow.png363.89 KBbjlewis2
#2 Border.png354.9 KBbjlewis2
Add Pathauto pattern | My site 2015-12-07 17-04-27.png79.87 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

bjlewis2’s picture

bjlewis2 commented
Issue summary: View changes
StatusFileSize
new Border.png354.9 KB
new Border and Shadow.png363.89 KB

I agree. We could add a border, and/or a light drop shadow. I've attached screenshots as examples.

Border

Border and Shadow

bjlewis2’s picture

bjlewis2 commented
Issue summary: View changes
hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
StatusFileSize
new sshot-block.png53.07 KB

I think this is a problem with Drupal core, not token. See the screenshot for the dialog on block layout page after removing the background.

Normally, there is a background for "Place Block" dialog because it is a modal dialog. The token browser is modal-less and does not get a background (as it shouldn't). But the styles for both the dialogs are same. I imagine there are no modal less dialogs used in Drupal core as this was not caught earlier.

Now, we should really fix this in core, but if we want to have a workaround here, we should be able to add a class to the dialog parent div and apply the styles from #2.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new sshot-token-tree.png28.14 KB
new 2630374-5.patch888 bytes

Here is how it looks after applying the workaround like I discussed in #4. Patch is attached as well.

hussainweb’s picture

hussainweb
Primary language English
commented

Also, created #2653942: Design for a non-modal dialog window...

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Well, the difference of adding it to the dialog itself vs. the wrapper is that white area showing on the top corners. You could still tie the css to the inner dialog even if the class is on the outer container, no?

hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new sshot-inner-div-shadow.png17.9 KB

If I do that, this is how it looks. Is this what you mean?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Hm. In #2, the shadow follows the curves in the grey header. In #5 it does not. That is what I meant. Looks like in #8 you moved it to only apply to the lower white area. I think that is still much better than the lack of shadow version, but not really what I meant :)

hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new 2630374-10.patch919 bytes
new sshot-tokentree-2.png24.58 KB

Ah, I think I see what you mean. This, right:

The patch is attached for that. The patch is small, so, I hope lack of interdiff is okay. :)

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Yeah. I think this is fine as a workaround for now to make this usable :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Works for me too.

  • Berdir committed 918d0d5 on 8.x-1.x authored by hussainweb 
    Issue #2630374 by hussainweb, bjlewis2: Token browser is hard to tell...
bjlewis2’s picture

bjlewis2 commented
StatusFileSize
new BottomRightCornerIssue.png7.63 KB

@hussainweb opened a followup issue for core, and I've uploaded a patch there that would fix this everywhere. I'd love a review!

https://www.drupal.org/node/2653942

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.