It's not working! I have an js error in my dev console after testing the module with all messages.

Comments

Anonymous’s picture

Anonymous (not verified) commented

w1Nz0r created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented

quiet long^^

bechtold’s picture

bechtold commented
Status: Active » Postponed (maintainer needs more info)

Hi,
thanks for reporting, but I can't reproduce any Problem.
The stuff you posted looks like a jQuery file, it has nothing todo with an error.
Did you have this problem in front- or backend?
How can I reproduce this?

Anonymous’s picture

Anonymous (not verified) commented

hi, i just installed the module and on the settings page i checked all message boxes. Because it wasn't working out of the box i checked the firefox dev tool and all i could see was the syntax error: unrecognized expression. Behind this error there was a link with the code above. I dont know if it has something to do with the module or maybe my testinstallation. I've made a fresh install yesterday and i will install the latest version later to see if the problem still occurs.

regards

w1nz0r

Anonymous’s picture

Anonymous (not verified) commented

So, i just installed the module on a fresh drupal 8.0.1 installation on apache server with php 5.6. It is not working. I tried out all example messages. I have no errors on the dblog page but as before firefox tells me that there is the same syntax error. I tried to clear caches without result. Do i have to add a message class on the settings page? i have no idea why it isn't working. I'm not sure what you mean with frontend and backend, but i've tested all possible scenarios like add content, comments and changing settings. Maybe because i'm using https?

regards

w1nz0r

bechtold’s picture

bechtold commented
Issue summary: View changes

Ok, I tested it in firefox again and I can't see a syntax error.
Can you post a screenshot of the bug please? Maybe this would help me.
It sounds like a JavaScript bug, not like a php bug, so the php version shouldn't make a difference.
With frontend I mean the page itself and with backend I mean the admin stuff.

I just realized, there is a bug for anonymous, because Drupal seems to be not available in the JavaScript.
Do you have your bug as logged in user and as anonymous user?

I will try to have a look at this again tonight.

bechtold’s picture

bechtold commented

I read your last post again and I think I found the bug now.
Yes there should be a message class set. It should have a default that is set on installation. Maybe that is the problem.
Maybe we should also set the class fields as required.

Try:
message class: messages
status message class: messages--status
warning message class: messages--warning
warning message class: messages--error

Anonymous’s picture

Anonymous (not verified) commented

ok...i added the above classes and now it's working. There wasn't a default message class predefined!

But the messages don't disappear totally, i still can see a part of about 10 px height. Would be cool if they could disappear totally, maybe with an checkbox to let admins decide which messages!?

Before it wasn't working on all pages including admin/*.

regards

w1nz0r

bechtold’s picture

bechtold commented
Status: Postponed (maintainer needs more info) » Needs work

Cool, I'm glad we found it.
Thanks for your contribution.
We'll fix it asap.

But the messages don't disappear totally, i still can see a part of about 10 px height. Would be cool if they could disappear totally, maybe with an checkbox to let admins decide which messages!?

Yeah, we thought it might be a bad idea if they completely disappear since the user could have not seen them at all. But adding this as an option for the site builder is a good idea. I added it to the future features list.

  • bechtold committed 6f12196 on 8.x-1.x 
    Issue #2629492 by w1Nz0r, bechtold: Fixed missing and wrong classes in...
bechtold’s picture

bechtold commented
Status: Needs work » Fixed

Just committed the fix and pushed a new alpha.
Thanks again for your help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.