Fragments missing since 7.x-2.x-beta6 for IE<=9. [#2628596]

When updating to beta 6 and 7 notice fragments/params are missing for IE<10. I decided to do a quick casting in order to solve it. There might more quick arounds .

Comment	File	Size	Author
#7	fragments_missing_since-2628596-7.patch	732 bytes	znerol
#7	7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 237 pass, 1 fail
#6	cached_fragment_missing-2628596-6.patch	735 bytes	angel.angelio
#6	7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 240 pass
#2	cached_fragment_missing-2628596.patch	733 bytes	angel.angelio
#2	7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 240 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 December 2015 at 00:52

angel.angelio created an issue. See original summary.

Comment #2

angel.angelio CreditAttribution: angel.angelio as a volunteer commented 4 December 2015 at 00:54

File	Size
cached_fragment_missing-2628596.patch	733 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 240 pass

Comment #3

angel.angelio CreditAttribution: angel.angelio as a volunteer commented 4 December 2015 at 00:58

Version:

7.x-2.0-beta7

» 7.x-2.x-dev

Comment #4

ChristianSanders CreditAttribution: ChristianSanders commented 10 December 2015 at 10:03

This patch works perfectly. We were having some issues with anon users in IE9 and this fixed those fantastically. Thank you very much! :)

Comment #5

znerol CreditAttribution: znerol commented 10 December 2015 at 11:12

+++ b/modules/authcache_ajax/authcache_ajax.js
@@ -44,7 +44,8 @@
-            var param = this;
+            // In IE8 this is an object -object window-.
+            var param = this.toString();

If this is really the window object in IE8, then simply converting that window object to a string is very likely wrong. Is that comment really correct?

Comment #6

angel.angelio CreditAttribution: angel.angelio as a volunteer commented 11 December 2015 at 00:12

File	Size
cached_fragment_missing-2628596-6.patch	735 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 240 pass

Znerol,

I fixed the comment. It is not the object window, it is a string object. I guess browsers different than IE<=9 happen to do the casting or this is a string constant for them

Comment #7

znerol CreditAttribution: znerol commented 11 December 2015 at 13:51

File	Size
fragments_missing_since-2628596-7.patch	732 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5 240 pass PHP 5.4 & MySQL 5.5 240 pass PHP 5.5 & MySQL 5.5 240 pass PHP 5.6 & MySQL 5.5 237 pass, 1 fail

Oh, so I'm starting to understand the problem. There are two kinds of strings in JavaScript (not only in MSIE): String Objects and String Literals.

Consider the following experiment (IE9 console, also works in other browsers):

>> obj = new String('test'); 
test {
	0 : "t",
	1 : "e",
	2 : "s",
	3 : "t",
	format : function(){return t(this,0,arguments)}
} 
Add to watch
>> lit = 'test'; 
"test" 
>> obj == lit; 
true 
>> obj === lit; 
false 
>> obj.toString() == lit; 
true 
>> obj.toString() === lit; 
true

This matters because authcache_ajax.js uses the identity operator (===) which also takes into account the data type. Note that the identity operator is preferable according to Douglas Crockford. I quickly checked Drupal 8 code base and I can confirm that it is used exclusively there.

Citing from the jQuery.each docs:

In the case of an array, the callback is passed an array index and a corresponding array value each time. (The value can also be accessed through the this keyword, but Javascript will always wrap the this value as an Object even if it is a simple string or number value.) The method returns its first argument, the object that was iterated.

This suggests that maybe the each callback should be changed instead (patch attached).

Comment #8

11 December 2015 at 13:58

Status:

Needs review

» Needs work

The last submitted patch, 7: fragments_missing_since-2628596-7.patch, failed testing.

Issue #2628596 by angel.angelio, znerol: Fragments missing since 7.x-2.x...

Comment #13

znerol CreditAttribution: znerol commented 13 December 2015 at 17:26

Status:

Needs work

» Fixed

Thank you very much for reporting this issue and for providing a fix.

Comment #14

27 December 2015 at 17:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #15

kevster CreditAttribution: kevster commented 15 January 2016 at 10:31

Many thanks - I just had this issue reported for customers when loading category pages and using authcache beta7. Weve just upgraded the server to latest ubuntu server LTS so has newer PHP and MySQL.

Issue occured only on IE 9 and 8 - the ajax content was just spinning and wouldnt load.

Great job - thanks!!