Closed (duplicate)
Project:
Image Widget Crop
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
2 Dec 2015 at 16:03 UTC
Updated:
7 Dec 2015 at 11:41 UTC
Jump to comment: Most recent
Having javascript code handling the actual crop selection is redundant since there are good libraries handling this. The code inside image_widget_crop.js is tied closely to a certain HTML structure and is very inflexible. It makes progress on #2625026: Crop widget crop list not following common patterns really hard, since we would need to rewrite the whole code of image_widget_crop.js.
My suggestion is to integrate this library: http://fengyuanchen.github.io/cropper/
It is the most widely used javascript image cropping library and is being actively developed.
Comments
Comment #2
luksakComment #3
woprrr commentedI asked a lot at the time of devellopements. The problem that the greater part of the most recent libraries is that we have an image that changes in one area and in my opinion it's not really a crop interface because it is not necessarily selects the crop area but moves the image in an area. For the initial project for which was develop the module it was not acceptable.
I quite agree to the "rigid" aspect of the current js own widget suposse because we always have the same structure, I did not imagine that to change much for the future and the reuse widget in the future is a good thing.
Currently I am preparing the common class and both widgets "standard" with the version you're trying to develop and "extended" who gets the look more "sexy" with the list of the widget. The advantage of this system will be able to plugger other crop widget without having to repeat all the party that provides intelligence ImageWidgetCrop (calculating positions / ui repercussion of the crop area on the original image etc ...)
Summarize my view to integrate cropper now and have a strucure more "standard".
Before that I think we have to have a perfect structure for html elements in the widget.
Comment #4
luksakSince the patch in #2625026: Crop widget crop list not following common patterns adds the Cropper library, I suggest we close this issue.