Hello,

The "Locating you..." message is displayed randomly on different page loads. I tracked down this to two issues:

1. The ip_geoloc.admin.inc uses filter_xss_admin() function to clean up the saved variable for the throbber text.
This means that if you enter <none>, this will NOT work, because the above mentioned function will remove everything.
You can test this simply by installing Devel, going to devel/php page and executing the following code:

// The output will be NULL. This means that saved value is erased.
dpm(filter_xss_admin('<none>'));
// The output will be <none>.
dpm('<none>');

2. The if statements should be fixed. Here's what I mean:

Now: if ($throbber_text !== '<none>') {
Should be: if ($throbber_text != '<none>') { (only one equation sign).

Patch will be attached shortly.

Let me know if you have any questions.

Thanks you!

Comments

topsitemakers created an issue. See original summary.

aramboyajyan’s picture

Patch is attached.

rdeboer’s picture

Thanks!
Rik

  • RdeBoer committed 971a542 on 7.x-1.x authored by topsitemakers
    Issue #2627334 by topsitemakers: IP Geoloc throbber default text issues
    
rdeboer’s picture

Priority: Major » Minor
Status: Needs review » Fixed

Patch applied.
Thanks again.
Rik

aramboyajyan’s picture

Sure, thanks for fast response Rik!

rdeboer’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.