Hello,
The "Locating you..." message is displayed randomly on different page loads. I tracked down this to two issues:
1. The ip_geoloc.admin.inc uses filter_xss_admin() function to clean up the saved variable for the throbber text.
This means that if you enter <none>, this will NOT work, because the above mentioned function will remove everything.
You can test this simply by installing Devel, going to devel/php page and executing the following code:
// The output will be NULL. This means that saved value is erased.
dpm(filter_xss_admin('<none>'));
// The output will be <none>.
dpm('<none>');
2. The if statements should be fixed. Here's what I mean:
Now: if ($throbber_text !== '<none>') {
Should be: if ($throbber_text != '<none>') { (only one equation sign).
Patch will be attached shortly.
Let me know if you have any questions.
Thanks you!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ip_geoloc-throbber-default-text-2627334-1-7.patch | 1.87 KB | aramboyajyan |
Comments
Comment #2
aramboyajyan commentedPatch is attached.
Comment #3
rdeboerThanks!
Rik
Comment #5
rdeboerPatch applied.
Thanks again.
Rik
Comment #6
aramboyajyan commentedSure, thanks for fast response Rik!
Comment #7
rdeboer